Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added BasicParametersMixin to Redshift #14752

Merged
merged 3 commits into from
May 24, 2021

Conversation

AAfghahi
Copy link
Member

SUMMARY

We are going through the most commonly used engine_specs and adding in the BasicParametersMixin and updating tests.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Added redshift and api tests.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #14752 (67e1e9e) into master (fbe6f16) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14752      +/-   ##
==========================================
- Coverage   77.54%   77.54%   -0.01%     
==========================================
  Files         962      962              
  Lines       49150    49154       +4     
  Branches     6183     6183              
==========================================
+ Hits        38114    38116       +2     
- Misses      10833    10835       +2     
  Partials      203      203              
Flag Coverage Δ
hive 81.35% <100.00%> (-0.01%) ⬇️
mysql 81.63% <100.00%> (-0.01%) ⬇️
postgres 81.65% <100.00%> (-0.01%) ⬇️
python 82.02% <100.00%> (-0.01%) ⬇️
sqlite 81.27% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/redshift.py 95.23% <100.00%> (+0.79%) ⬆️
superset/databases/schemas.py 98.71% <0.00%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbe6f16...67e1e9e. Read the comment docs.

get_available_engine_specs.return_value = [
PostgresEngineSpec,
MySQLEngineSpec,
RedshiftEngineSpec,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a big query test here as well, make sure you rebase

@hughhhh hughhhh merged commit 904b60e into apache:master May 24, 2021
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request May 25, 2021
* master: (163 commits)
  fix(native-filters): Manage default value of filters by superset (apache#14785)
  fix: Additional ResultSet tests (apache#14741)
  chore: added BasicParametersMixin to Redshift (apache#14752)
  fix: make dataset list sort case insensitive (apache#14528)
  fix: use encodeURIComponent when getting table metadata (apache#14790)
  fix: ensure engine is outside parameters (apache#14787)
  database modal should close on connect with tab layout (apache#14771)
  feat(native-filters): add search all filter options (apache#14710)
  fix: extra query in Dashboard when native filter enabled (apache#14770)
  chore: Improves the native filters UI/UX - iteration 2 (apache#14753)
  fix(native filters): Fix explore state (apache#14779)
  fix(explore): DndColumnSelect not handling controls with "multi: false" (apache#14737)
  feat: Create BigQuery Parameters for DatabaseModal (apache#14721)
  feat: enable user impersonation in GSheets (apache#14767)
  fix: add DB should not say it's Postgres (apache#14766)
  Revert "fix(dashboard): multiple query trigger when native filter enabled (apache#14734)" (apache#14762)
  feat: save database with new dynamic form (apache#14583)
  fix: save non-parameter DBs (apache#14759)
  chore: Removes ColorSchemeControl.less (apache#14199)
  fix(explore): Icons width (apache#14717)
  ...
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* redshift basic mixin and tests

* rebased

* forgot prefix
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* redshift basic mixin and tests

* rebased

* forgot prefix
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* redshift basic mixin and tests

* rebased

* forgot prefix
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants