ci: make presto hive tests to cover only chartData and sqljson

[amitmiran137]

SUMMARY

there have been a few attempts already to avoid the flakiness of the presto hive tests
in addition, we know that the original intention of that workflow was to test out the engine part of presto and hive
therefore we can just limit the tests the chart/data and sql_json API's which are executing the data querying part of superset

#17772
resolves #17750

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #17782 (8c3c65d) into master (886e4ef) will increase coverage by 0.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #17782      +/-   ##
==========================================
+ Coverage   66.73%   67.08%   +0.34%     
==========================================
  Files        1609     1609              
  Lines       64897    64897              
  Branches     6866     6866              
==========================================
+ Hits        43306    43533     +227     
+ Misses      19725    19498     -227     
  Partials     1866     1866              

Flag	Coverage Δ
hive	53.29% <ø> (?)
javascript	53.77% <ø> (ø)
mysql	82.19% <ø> (?)
postgres	82.24% <ø> (?)
presto	53.13% <ø> (?)
python	82.68% <ø> (+0.76%)	⬆️
sqlite	81.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/utils/core.py	89.76% <0.00%> (+0.11%)	⬆️
superset/reports/commands/execute.py	91.28% <0.00%> (+0.37%)	⬆️
superset/views/base_api.py	98.31% <0.00%> (+0.42%)	⬆️
superset/views/core.py	77.81% <0.00%> (+0.44%)	⬆️
superset/jinja_context.py	89.84% <0.00%> (+0.50%)	⬆️
superset/common/query_object.py	95.62% <0.00%> (+0.54%)	⬆️
superset/db_engine_specs/base.py	88.67% <0.00%> (+0.76%)	⬆️
superset/sql_lab.py	81.64% <0.00%> (+1.17%)	⬆️
superset/views/database/views.py	88.46% <0.00%> (+1.28%)	⬆️
superset/connectors/sqla/models.py	88.31% <0.00%> (+1.57%)	⬆️
... and 18 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 886e4ef...8c3c65d. Read the comment docs.

[amitmiran137]

Presto/Hive tests are running only 2 suites of tests now chartData nd sql_lab.
for some reason a single test is failing, can @apache/superset-committers

[etr2460]

are there database creation/api tests we should include here too?

[amitmiran137]

are there database creation/api tests we should include here too?

Can you explain a bit why you think it is related?

[etr2460]

I wanted to make sure that any tests that might hit the presto/hive connectors get run here. For example, a test that adds custom configuration options to a database (and passes them on to the db engine). some examples of the configs:

there's also the db impersonation that i believe is unique on a db engine level. Ideally we would be testing all these config options on every db engine, but for now hive and presto is a start

[amitmiran137]

@etr2460 can you point the relevant tests that you want to be covered here?
we can easily mark them on the same technique
you can even at the marks yourself and commit to this branch, but lets address this painpoint as soon as possible

[etr2460]

i don't know the specific ones (not super familiar with the backend) so i'll stamp to unblock here. @bkyryliuk @villebro and @john-bodley would probably be the ones who know most about the backend to tag other tests. but this seems like a decent step (and could allow us to make these tests required for PRs too)

[amitmiran137]

Hive and presto bottle tests bottle neck shrink to 6-7 minutes ✌️

[bkyryliuk]

i don't know the specific ones (not super familiar with the backend) so i'll stamp to unblock here. @bkyryliuk @villebro and @john-bodley would probably be the ones who know most about the backend to tag other tests. but this seems like a decent step (and could allow us to make these tests required for PRs too)

just noticed the comment, I think we can enable presto / hive tests later on for the cases that are critical or if we will notice breakages.