Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: make presto hive tests to cover only chartData and sqljson #17782

Merged
merged 6 commits into from
Dec 31, 2021
Merged

ci: make presto hive tests to cover only chartData and sqljson #17782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4a29ba6
chore: make presto hive tests to cover only chartData and sqljson
amitmiran137 Dec 16, 2021
f4ca4e4
fix: single quote
amitmiran137 Dec 16, 2021
e70c8e5
fix: add eval for arguments
amitmiran137 Dec 16, 2021
3251448
fix: add double quotes on args
amitmiran137 Dec 16, 2021
883aff6
chore: add @pytest.mark.sql_json_flow
amitmiran137 Dec 16, 2021
8c3c65d
fix: pre-commit
amitmiran137 Dec 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/superset-python-presto-hive.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ jobs:
- name: Python unit tests (PostgreSQL)
if: steps.check.outcome == 'failure'
run: |
./scripts/python_tests.sh
./scripts/python_tests.sh -m 'chart_data_flow or sql_json_flow'
- name: Upload code coverage
if: steps.check.outcome == 'failure'
run: |
Expand Down Expand Up @@ -158,7 +158,7 @@ jobs:
- name: Python unit tests (PostgreSQL)
if: steps.check.outcome == 'failure'
run: |
./scripts/python_tests.sh
./scripts/python_tests.sh -m 'chart_data_flow or sql_json_flow'
- name: Upload code coverage
if: steps.check.outcome == 'failure'
run: |
Expand Down
3 changes: 2 additions & 1 deletion scripts/python_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,5 @@ superset db upgrade
superset init

echo "Running tests"
pytest --durations=0 --maxfail=1 --cov=superset $@

pytest --durations=0 --maxfail=1 --cov=superset "$@"
1 change: 1 addition & 0 deletions tests/integration_tests/sqllab_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@
QUERY_3 = "SELECT * FROM birth_names LIMIT 10"


@pytest.mark.sql_json_flow
class TestSqlLab(SupersetTestCase):
"""Testings for Sql Lab"""

Expand Down