fix(import_datasources): --sync flag works correctly #18046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s cli command. Also added unit tests for all of the edge cases (with both metrics & columns, with just columns, and with just metrics)
…Removing it might cause headaches for someone trying to work on this particular piece of code in the future
cccs-Dustin
changed the title
|
@geido Are you able to approve running workflows for me as I am a first-time contributor? |
Sure thing |
cccs-Dustin
changed the title
…ts since the merge
…ts since the merge
…om:CybercentreCanada/superset into fix/superset-cli-import-datasources-s-flag Updated the cli_tests.py file as the merge that was completed changed the format of the unit test. I needed to update my unit tests to the new format
cccs-Dustin
changed the title
Codecov Report
@@ Coverage Diff @@
## master #18046 +/- ##
=======================================
Coverage 65.94% 65.95%
=======================================
Files 1584 1584
Lines 62055 62055
Branches 6273 6273
=======================================
+ Hits 40925 40926 +1
+ Misses 19509 19508 -1
Partials 1621 1621
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
betodealmeida
approved these changes
Jan 24, 2022
shcoderAlex
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 7, 2022
* Added code that properly accepts the -s flag on the import-datasources cli command. Also added unit tests for all of the edge cases (with both metrics & columns, with just columns, and with just metrics) * Files were reformated using the 'pre-commit run --all-files' command * added '*args: Any' back into v0.py as it did not need to be removed. Removing it might cause headaches for someone trying to work on this particular piece of code in the future * Fixed the merge conflict as the cli.py was moved to another directory * Modified my created unit tests to work with the new format of uni tests since the merge * Modified my created unit tests to work with the new format of uni tests since the merge * Fixed errors which were encountered while using the unit tests
ofekisr
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Feb 8, 2022
* Added code that properly accepts the -s flag on the import-datasources cli command. Also added unit tests for all of the edge cases (with both metrics & columns, with just columns, and with just metrics) * Files were reformated using the 'pre-commit run --all-files' command * added '*args: Any' back into v0.py as it did not need to be removed. Removing it might cause headaches for someone trying to work on this particular piece of code in the future * Fixed the merge conflict as the cli.py was moved to another directory * Modified my created unit tests to work with the new format of uni tests since the merge * Modified my created unit tests to work with the new format of uni tests since the merge * Fixed errors which were encountered while using the unit tests
bwang221
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 10, 2022
* Added code that properly accepts the -s flag on the import-datasources cli command. Also added unit tests for all of the edge cases (with both metrics & columns, with just columns, and with just metrics) * Files were reformated using the 'pre-commit run --all-files' command * added '*args: Any' back into v0.py as it did not need to be removed. Removing it might cause headaches for someone trying to work on this particular piece of code in the future * Fixed the merge conflict as the cli.py was moved to another directory * Modified my created unit tests to work with the new format of uni tests since the merge * Modified my created unit tests to work with the new format of uni tests since the merge * Fixed errors which were encountered while using the unit tests
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
/superset/superset/cli.py, as the previous code was not properly assigning a boolean value to sync_columns and sync_metrics.superset/tests/integration_tests/cli_tests.pyfor 3 new unit tests to make sure the --sync flag is working correctly.By modifying the code in
/superset/superset/cli.py, the Superset import_datasources cli now correctly functions with the --sync flag.TESTING INSTRUCTIONS
superset import-datasources -p ~/datasets/data.yamlsuperset import-datasources -s "metrics,columns" -p ~/datasets/data.yamlADDITIONAL INFORMATION