Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(import_datasources): --sync flag works correctly #18046

Merged
merged 10 commits into from
Jan 25, 2022
Merged

fix(import_datasources): --sync flag works correctly #18046

merged 10 commits into from
Jan 25, 2022

Commits on Jan 13, 2022

  1. Added code that properly accepts the -s flag on the import-datasource… 

    …s cli command. Also added unit tests for all of the edge cases (with both metrics & columns, with just columns, and with just metrics)
    @cccs-Dustin
    cccs-Dustin committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    956e113 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2022

  1. Files were reformated using the 'pre-commit run --all-files' command

    @cccs-Dustin
    cccs-Dustin committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    471c421 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'apache:master' into fix/superset-cli-import-datasources… 

    …-s-flag
    @cccs-Dustin
    cccs-Dustin authored Jan 14, 2022
    Configuration menu
    Copy the full SHA
    11a6798 View commit details
    Browse the repository at this point in the history

  3. added '*args: Any' back into v0.py as it did not need to be removed. … 

    …Removing it might cause headaches for someone trying to work on this particular piece of code in the future
    @cccs-Dustin
    cccs-Dustin committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    009402a View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. Fixed the merge conflict as the cli.py was moved to another directory

    @cccs-Dustin
    cccs-Dustin committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    5d8abfb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/superset-cli-import-datasources-s-flag

    @cccs-Dustin
    cccs-Dustin authored Jan 24, 2022
    Configuration menu
    Copy the full SHA
    54b6bb2 View commit details
    Browse the repository at this point in the history

  3. Modified my created unit tests to work with the new format of uni tes… 

    …ts since the merge
    @cccs-Dustin
    cccs-Dustin committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    f3fb14b View commit details
    Browse the repository at this point in the history

  4. Modified my created unit tests to work with the new format of uni tes… 

    …ts since the merge
    @cccs-Dustin
    cccs-Dustin committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    3551061 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'fix/superset-cli-import-datasources-s-flag' of github.c… 

    …om:CybercentreCanada/superset into fix/superset-cli-import-datasources-s-flag

Updated the cli_tests.py file as the merge that was completed changed the format of the unit test. I needed to update my unit tests to the new format
    @cccs-Dustin
    cccs-Dustin committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    5488902 View commit details
    Browse the repository at this point in the history

  6. Fixed errors which were encountered while using the unit tests

    @cccs-Dustin
    cccs-Dustin committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    bfbb70f View commit details
    Browse the repository at this point in the history