Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(migrations): Renaming migration files so that they're easier to keep track of #20284

Merged
merged 4 commits into from
Jun 7, 2022

Conversation

craig-rueda
Copy link
Member

SUMMARY

Renames all DB migrations (and updates the format in alembic.ini) so that simple alpha sorts will yield the migration order. The current format makes searching through alembic versions cumbersome and this simple fix aims to solve this!

Note that no Alembic revision numbers were harmed in this PR -- just filenames :)

@craig-rueda craig-rueda requested a review from a team as a code owner June 6, 2022 20:06
@betodealmeida
Copy link
Member

Looks like one of the migrations imports another migration, they need to be fixed:

# superset/migrations/versions/2021-02-18_09-13_c501b7c653a3_add_missing_uuid_column.py
from superset.migrations.versions.b56500de1855_add_uuid_column_to_import_mixin import (

Looks like it's just that one:

% git grep -l 'from superset.migrations.versions'
c501b7c653a3_add_missing_uuid_column.py

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Jun 7, 2022
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jun 7, 2022
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #20284 (40b2bf9) into master (6f0d53e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #20284   +/-   ##
=======================================
  Coverage   66.65%   66.65%           
=======================================
  Files        1729     1729           
  Lines       64910    64910           
  Branches     6842     6842           
=======================================
  Hits        43268    43268           
  Misses      19893    19893           
  Partials     1749     1749           
Flag Coverage Δ
hive 53.70% <ø> (ø)
mysql 82.28% <ø> (ø)
postgres 82.35% <ø> (ø)
presto 53.56% <ø> (ø)
python 82.78% <ø> (ø)
sqlite 82.09% <ø> (ø)
unit 50.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f0d53e...40b2bf9. Read the comment docs.

@craig-rueda craig-rueda merged commit d1c24f8 into apache:master Jun 7, 2022
@craig-rueda craig-rueda deleted the craig/rename-migrations branch June 7, 2022 17:30
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants