Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(migrations): Renaming migration files so that they're easier to keep track of #20284

Merged
merged 4 commits into from
Jun 7, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion superset/migrations/alembic.ini
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

[alembic]
# template used to generate migration files
# file_template = %%(rev)s_%%(slug)s
file_template = %%(year)d-%%(month).2d-%%(day).2d_%%(hour).2d-%%(minute).2d_%%(rev)s_%%(slug)s

# set to 'true' to run the environment during
# the 'revision' command, regardless of autogenerate
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,21 +27,24 @@
down_revision = "070c043f2fdb"

import logging
from importlib import import_module
from uuid import uuid4

import sqlalchemy as sa
from alembic import op
from sqlalchemy.dialects import mysql
from sqlalchemy.engine.reflection import Inspector
from sqlalchemy.orm import load_only
from sqlalchemy_utils import UUIDType

from superset import db
from superset.migrations.versions.b56500de1855_add_uuid_column_to_import_mixin import (
assign_uuids,
models,
update_dashboards,

add_uuid_column_to_import_mixin = import_module(
"superset.migrations.versions."
"2020-09-28_17-57_b56500de1855_add_uuid_column_to_import_mixin",
)
assign_uuids = add_uuid_column_to_import_mixin.assign_uuids
models = add_uuid_column_to_import_mixin.models
update_dashboards = add_uuid_column_to_import_mixin.update_dashboards


def has_uuid_column(table_name, bind):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,14 @@
# specific language governing permissions and limitations
# under the License.
import json
from importlib import import_module

from superset.migrations.versions.ad07e4fdbaba_rm_time_range_endpoints_from_qc_3 import (
Slice,
upgrade_slice,
rm_time_range_endpoints_from_qc_3 = import_module(
"superset.migrations.versions."
"2022-04-18_11-20_ad07e4fdbaba_rm_time_range_endpoints_from_qc_3",
)
Slice = rm_time_range_endpoints_from_qc_3.Slice
upgrade_slice = rm_time_range_endpoints_from_qc_3.upgrade_slice

sample_query_context = {
"datasource": {"id": 27, "type": "table"},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,14 @@
# specific language governing permissions and limitations
# under the License.
from copy import deepcopy
from importlib import import_module

from superset.migrations.versions.f1410ed7ec95_migrate_native_filters_to_new_schema import (
downgrade_dashboard,
upgrade_dashboard,
migrate_native_filters_to_new_schema = import_module(
"superset.migrations.versions."
"2021-04-29_15-32_f1410ed7ec95_migrate_native_filters_to_new_schema",
)
downgrade_dashboard = migrate_native_filters_to_new_schema.downgrade_dashboard
upgrade_dashboard = migrate_native_filters_to_new_schema.upgrade_dashboard

dashboard_v1 = {
"native_filter_configuration": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,13 @@
# specific language governing permissions and limitations
# under the License.
import json
from importlib import import_module

from superset.migrations.versions.fb13d49b72f9_better_filters import (
Slice,
upgrade_slice,
better_filters = import_module(
"superset.migrations.versions." "2018-12-11_22-03_fb13d49b72f9_better_filters",
)
Slice = better_filters.Slice
upgrade_slice = better_filters.upgrade_slice


def test_upgrade_slice():
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,15 @@
# specific language governing permissions and limitations
# under the License.
from copy import deepcopy
from importlib import import_module

from superset.migrations.versions.fc3a3a8ff221_migrate_filter_sets_to_new_format import (
downgrade_filter_set,
upgrade_filter_set,
upgrade_select_filters,
migrate_filter_sets_to_new_format = import_module(
"superset.migrations.versions."
"2021-04-12_12-38_fc3a3a8ff221_migrate_filter_sets_to_new_format",
)
downgrade_filter_set = migrate_filter_sets_to_new_format.downgrade_filter_set
upgrade_filter_set = migrate_filter_sets_to_new_format.upgrade_filter_set
upgrade_select_filters = migrate_filter_sets_to_new_format.upgrade_select_filters

native_filters_v1 = [
{
Expand Down