Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HelmChart): Configurable securityContext in Pods #20509

Merged
merged 3 commits into from
Jul 5, 2022
Merged

feat(HelmChart): Configurable securityContext in Pods #20509

merged 3 commits into from
Jul 5, 2022

Conversation

miloszbednarzak
Copy link
Contributor

SUMMARY

This PR introduces the possibility to customize securityContext in Kubernetes Pods, which is necessary if one wants to have compatibility with the Pod Security Standards.
see https://kubernetes.io/blog/2021/12/09/pod-security-admission-beta/

TESTING INSTRUCTIONS

In order to test changes, one needs to change securityContext specification in values.yaml for any Pod and check if after deployment it changed desired outcome in deployed Pod.

ADDITIONAL INFORMATION

  • Has associated issue: Helm Chart pod definitions do not allow to modify pod securityContext #20489
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@miloszbednarzak
Copy link
Contributor Author

@craig-rueda should we do anything more until merging, do we need another review or can we proceed?

@craig-rueda craig-rueda merged commit 1a80668 into apache:master Jul 5, 2022
@miloszbednarzak miloszbednarzak deleted the configurable-securityContext branch July 5, 2022 19:16
akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
* feat(Helm Chart): add customizable securityContext

* build(Helm Chart): bump Chart to 0.6.4

* feat(Helm Chart): add support for securityContext
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants