feat(HelmChart): Add securityContext on pod level #20611
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miloszbednarzak
requested review from
craig-rueda,
dpgaspar and
villebro
as code owners
miloszbednarzak
commented
Jul 5, 2022
* feat: Adds the /explore endpoint to the v1 API * Fixes pylint errors * Fixes tests * Changes the tests logic * Removes ABC reference * Improves indentation * Addresses review comments * Rebases code * Improves dataset and slice assertions * Fixes tests * Removes schema and table name assertions * Removes fixed IDs * Fixes datasource ID
* chore: Restructure explore redux state * fixes * fix tests * add new tests * Fix type * Address comments * Fix bug * Fix import * Add new test * Move unsaved chart id to a constant * Add todo
Co-authored-by: Multazim Deshmukh <multazim.deshmukh@morningstar.com>
…ent setup instructions (#20260) * Remove incompatible Python 3.7 from local env setup docs * Ensure Python 3.8 or 3.9 Co-authored-by: Diego Martin <diego.martin@indigitall.com>
Co-authored-by: John Bodley <john.bodley@airbnb.com>
…ics (#20473) Co-authored-by: John Bodley <john.bodley@airbnb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Follow up on #20509
It is also worth add securityContext configuration on a container level.
TESTING INSTRUCTIONS
In order to test changes, one needs to change securityContext specification in values.yaml for any Container and check if after deployment it changed desired outcome in deployed Container.
ADDITIONAL INFORMATION