Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bar-chart): change legend padding for horizontal orientation #27883

Merged
merged 1 commit into from
Apr 3, 2024
Merged

fix(bar-chart): change legend padding for horizontal orientation #27883

merged 1 commit into from
Apr 3, 2024

Conversation

lilykuang
Copy link
Member

SUMMARY

  • Bar Chart v2 Horizontal bar with temporal Y-Axis is plotted out of axis

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
bar-chart-before

After:
bar-chart

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@lilykuang lilykuang merged commit cfa0556 into master Apr 3, 2024
33 of 34 checks passed
@rusackas rusackas deleted the bar-chart-fix-legend-padding branch April 4, 2024 01:03
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request Apr 4, 2024
@jzhao62
fix(bar-chart): change legend padding for horizontal orientation (apa…
94b6b76 
…che#27883)
@michael-s-molina michael-s-molina added v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch labels Apr 4, 2024
michael-s-molina pushed a commit that referenced this pull request Apr 4, 2024
@michael-s-molina
fix(bar-chart): change legend padding for horizontal orientation (#27883
863461d 
)

(cherry picked from commit cfa0556)
EandrewJones pushed a commit to UMD-ARLIS/superset that referenced this pull request Apr 5, 2024
@EandrewJones
fix(bar-chart): change legend padding for horizontal orientation (apa…
a989b7f 
…che#27883)
michael-s-molina pushed a commit that referenced this pull request Apr 8, 2024
@michael-s-molina
fix(bar-chart): change legend padding for horizontal orientation (#27883
300669f 
)

(cherry picked from commit cfa0556)
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 12, 2024
@EnxDev
fix(bar-chart): change legend padding for horizontal orientation (apa…
67788c0 
…che#27883)
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
@qleroy
fix(bar-chart): change legend padding for horizontal orientation (apa…
f247f2c 
…che#27883)
@scarbeau
Copy link

@lilykuang we just upgraded and this fix appears to be causing excess padding with all our bar charts, see below.

Screenshot 2024-06-21 at 11 25 36 AM

@sfirke
Copy link
Member

sfirke commented Jun 21, 2024

@scarbeau good timing, I am experiencing this bug too and just traced it back to this PR. I will open a new issue.

@seandiacono seandiacono mentioned this pull request Jun 24, 2024
Closed
3 tasks
@michael-s-molina michael-s-molina mentioned this pull request Jun 24, 2024
Merged
9 tasks
@rusackas
Copy link
Member

The PR was reverted, so the new issue should be gone.

@mistercrunch mistercrunch added 🍒 3.1.3 🍒 4.0.1 🍒 4.0.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antonio-RiveroMartnez Antonio-RiveroMartnez Antonio-RiveroMartnez approved these changes

@kgabryje kgabryje Awaiting requested review from kgabryje

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels plugins size/S v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🍒 3.1.3 🍒 4.0.1 🍒 4.0.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lilykuang @scarbeau @sfirke @rusackas @Antonio-RiveroMartnez @mistercrunch @michael-s-molina