fix(revert 27883): Excess padding in horizontal Bar charts #29345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-s-molina
requested review from
rusackas,
lilykuang,
villebro and
Antonio-RiveroMartnez
dosubot
bot
added
viz:charts:bar
rusackas
reviewed
Jun 24, 2024
| @@ -571,10 +571,6 @@ export function getPadding( | |||
| ? TIMESERIES_CONSTANTS.yAxisLabelTopOffset | |||
| : 0; | |||
| const xAxisOffset = addXAxisTitleOffset ? Number(xAxisTitleMargin) || 0 : 0; | |||
| const showLegendTopOffset = | |||
| isHorizontal && showLegend && legendOrientation === LegendOrientation.Top | |||
| ? 100 | |||
There was a problem hiding this comment.
Do we need to revert the whole thing, or should this 100px just be a more reasonable number?
There was a problem hiding this comment.
You cannot set a fixed padding because it will depend on the size of each bar generated by ECharts, which will also vary depending on the number of bars. This calculation should be done automatically by ECharts.
rusackas
changed the title
rusackas
approved these changes
Jun 24, 2024
michael-s-molina
added
the
v4.0
michael-s-molina
added a commit
that referenced
this pull request
Jun 26, 2024
(cherry picked from commit 708afb7)
3 tasks
9 tasks
mistercrunch
added
🍒 4.0.2
🏷️ bot
eschutho
pushed a commit
that referenced
this pull request
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR reverts #27883 which incorrectly calculated the chart's padding and introduced #29342.
There's a bug with
yAxis.inversein ECharts and we don't know when a fix will be provided. To fix this issue, this PR partially reverts #23273 which introduced said configuration. I'm purposefully not adding a migration to this PR, as #23273 did, so it can be cherry-picked as it's affecting all 4.0.x versions. This will change the default y-axis order of horizontal bar charts. @yousophAn alternative solution, would be to fix the ECharts bug. @villebro
Fixes #29342
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
1 - Create an horizontal bar chart using a time column in the x-axis
2 - Check that the chart is displayed correctly.
ADDITIONAL INFORMATION