Moving static colors over to Less vars

[rusackas]

CATEGORY

Choose one

• Bug Fix
• Enhancement (new features, refinement)
• Refactor
• Add tests
• Build / Development Environment
• Documentation

SUMMARY

Making it easier to change colors around in the future, and catching a few inconsistencies at the same time. Part of a general effort to move "themable" bits into vars for global re-use.

[codecov-io]

Codecov Report

Merging #8563 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8563   +/-   ##
=======================================
  Coverage   65.77%   65.77%           
=======================================
  Files         482      482           
  Lines       23794    23794           
  Branches     2587     2587           
=======================================
  Hits        15651    15651           
  Misses       7974     7974           
  Partials      169      169

Impacted Files	Coverage Δ
superset/assets/src/welcome/DashboardTable.jsx	87.5% <ø> (ø)	⬆️
superset/assets/src/profile/App.jsx	0% <ø> (ø)	⬆️
superset/assets/src/SqlLab/App.jsx	0% <ø> (ø)	⬆️
.../explore/components/controls/DatasourceControl.jsx	67.74% <ø> (ø)	⬆️
superset/assets/src/components/FilterBadgeIcon.jsx	50% <ø> (ø)	⬆️
superset/assets/src/components/TableLoader.jsx	6.66% <ø> (ø)	⬆️
superset/assets/src/components/FilterEditIcon.jsx	50% <ø> (ø)	⬆️
...uperset/assets/src/datasource/DatasourceEditor.jsx	63.39% <ø> (ø)	⬆️
superset/assets/src/explore/App.jsx	0% <ø> (ø)	⬆️
...t/assets/src/components/BootstrapSliderWrapper.jsx	0% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e490414...8939161. Read the comment docs.

[rusackas]

I think that's enough for one PR... I'll make additional PRs soon to tackle the following:
• Moving other files from .css to .less (might as well conform things!)
• Consolidating typographic styles
• Cleaning out dead CSS selectors/files

[suddjian]

Looks awesome, let's merge it!

[mistercrunch]

[rusackas]

Just for posterity, here are the color mappings from this PR

• @almost-black
  • #263238
• @danger
  • red
• @darkest
  • black,rgba(0, 0, 0)
• @error
  • red
• @gray
  • #949494, #9e9e9e, #808e95,#666666,grey,#888888
• @gray-bg
  • #efefef,#e8e8e8,#f2f2f2,f4f4f4,#eeeeee,#f8f8f8
• @gray-dark
  • #555555, rgb(72, 72, 72),#484848,#667177
• @gray-heading
  • #aaaaaa
• @gray-light
  • b3b3b3 , bababa, #dddddd,rgb(187,187,187),#bbbbbb,#ccc,rgb(219, 219, 219)
• @indicator-color
  • #e32464,#2c2261,rgb(68, 192, 255)
• @lightest
  • #fff,white,rgb(255, 255, 255)
• @success
  • lime, #4ac15f
• @shadow-highlight
  • rgb(0, 166, 153)
• @warning
  • orange,#fe4a49