Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL Lab] Re-add erroneously removed css #8707

Merged
merged 1 commit into from
Dec 2, 2019

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Dec 2, 2019

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

#8563 removed some assumed dead css, but it's actually still being used to style the gripper for resizing the sql editor and closing the side pane. This PR readds it.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TEST PLAN

ensure you can resize the sql editor and open and close the side pane

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@rusackas @graceguo-supercat @nytai

@codecov-io
Copy link

codecov-io commented Dec 2, 2019

Codecov Report

Merging #8707 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8707      +/-   ##
==========================================
+ Coverage   65.51%   65.55%   +0.04%     
==========================================
  Files         481      481              
  Lines       24081    24081              
  Branches     2763     2763              
==========================================
+ Hits        15776    15786      +10     
+ Misses       8125     8115      -10     
  Partials      180      180
Impacted Files Coverage Δ
superset/db_engine_specs/postgres.py 83.33% <0%> (+27.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd91f33...dbd20d2. Read the comment docs.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wish I could approve this for real, but I'll give it the gray checkmark at least... and thanks for spotting/fixing this. Apologies for the heavy-handed deletion.

@etr2460 etr2460 merged commit e06a138 into apache:master Dec 2, 2019
@etr2460 etr2460 deleted the erik-ritter--fix-sql-lab-css branch December 2, 2019 18:09
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants