Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom cloneDeep function #3881

Merged
merged 2 commits into from
Sep 4, 2018
Merged

Replace custom cloneDeep function #3881

merged 2 commits into from
Sep 4, 2018

Conversation

hwillson
Copy link
Member

@hwillson hwillson commented Sep 4, 2018

The custom cloneDeep function we're using in the apollo-utilities package doesn't handle circular references well (as in it crashes if it hits one). These changes replace the custom cloneDeep implementation with fclone, which is a dependency free, lightweight and performant deep clone implementation. fclone drops circular references (replacing them with a [Circular] string).

Fixes #1717.

The custom `cloneDeep` function we're using in the
`apollo-utilities` package doesn't handle circular references
well (as in it crashes if it hits one). These changes replace
the custom `cloneDeep` implementation with `fclone`, which is
a dependency free, lightweight and performant deep clone
implementation. `fclone` drops circular references
(replacing them with a `[Circular]` string).

Fixes #1717.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant