Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace custom cloneDeep function #3881

Merged
merged 2 commits into from
Sep 4, 2018
Merged

Replace custom cloneDeep function #3881

merged 2 commits into from
Sep 4, 2018

Commits on Sep 4, 2018

  1. Replace custom cloneDeep function 

    The custom `cloneDeep` function we're using in the
`apollo-utilities` package doesn't handle circular references
well (as in it crashes if it hits one). These changes replace
the custom `cloneDeep` implementation with `fclone`, which is
a dependency free, lightweight and performant deep clone
implementation. `fclone` drops circular references
(replacing them with a `[Circular]` string).

Fixes #1717.
    @hwillson
    hwillson committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    a704888 View commit details
    Browse the repository at this point in the history

  2. Changelog update

    @hwillson
    hwillson committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    4d00d69 View commit details
    Browse the repository at this point in the history