Enable generate_query_fragments by default
#6013
Conversation
The router previously had `experimental_reuse_query_fragments` enabled by default when trying to optimize fragments before sending operations to subgraphs. While on occasion this algorithm can be more performant, we found that in vast majority of cases the query planner can be just as performant using `generate_query_fragments` query plan option, which also significantly reduces query size being sent to subgraphs. While the two options will produce correct responses, the queries produced internally by the query planner will differ. This change enables `generate_query_fragments` by default, while disabling `experimental_reuse_query_fragments`. You can change this behavior with the following options: ```yaml supergraph: generate_query_fragments: false experimental_reuse_query_fragments: true ```
| /// Default: true | ||
| #[serde(default = "default_generate_query_fragments")] |
There was a problem hiding this comment.
this fails our own default tests:
The only way for this config to have its own Default implementation is to be defined as an enum/struct, which feels wayyy too much for something like this. Any other ideas on setting up a default in a single place for this config?
There was a problem hiding this comment.
Remove #[serde(default = "default_generate_query_fragments")] and replace two instances of generate_query_fragments.unwrap_or_default() in this file with generate_query_fragments.unwrap_or_else(default_generate_query_fragments)
Since the struct already has #[serde(default)] serde will rely on the existing impl Default for Supergraph
There was a problem hiding this comment.
i felt that using unwrap_or_else hid away the default definition. but i guess since we've got a doc comment with Default: true it's maybe a bit more clear.
Co-authored-by: Renée <renee.kooi@apollographql.com>
The router previously had
experimental_reuse_query_fragmentsenabled by default when trying to optimize fragments before sending operations to subgraphs. While on occasion this algorithm can be more performant, we found that in vast majority of cases the query planner can be just as performant usinggenerate_query_fragmentsquery plan option, which also significantly reduces query size being sent to subgraphs. While the two options will produce correct responses, the queries produced internally by the query planner will differ.This change enables
generate_query_fragmentsby default, while disablingexperimental_reuse_query_fragments. You can change this behavior with the following options: