Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable generate_query_fragments by default #6013

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Enable generate_query_fragments by default #6013

wants to merge 5 commits into from

Commits on Sep 17, 2024

  1. Enable generate_query_fragments by default 

    The router previously had `experimental_reuse_query_fragments` enabled by
default when trying to optimize fragments before sending operations to subgraphs.
While on occasion this algorithm can be more performant, we found that in vast
majority of cases the query planner can be just as performant using
`generate_query_fragments` query plan option, which also significantly reduces
query size being sent to subgraphs. While the two options will produce correct
responses, the queries produced internally by the query planner will differ.

This change enables `generate_query_fragments` by default, while disabling
`experimental_reuse_query_fragments`. You can change this behavior with the
following options:

```yaml
supergraph:
  generate_query_fragments: false
  experimental_reuse_query_fragments: true
```
    @lrlna
    lrlna committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    be83e30 View commit details
    Browse the repository at this point in the history

  2. update config snapshot

    @lrlna
    lrlna committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    ee0975d View commit details
    Browse the repository at this point in the history

  3. Update docs/source/configuration/overview.mdx 

    Co-authored-by: Renée <renee.kooi@apollographql.com>
    @lrlna @goto-bus-stop
    lrlna and goto-bus-stop committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    cd3c249 View commit details
    Browse the repository at this point in the history

  4. use unwrap_or_else for generate_query_fragments defaults

    @lrlna
    lrlna committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    1daae5d View commit details
    Browse the repository at this point in the history

  5. update redis cache keys

    @lrlna
    lrlna committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    51e89cb View commit details
    Browse the repository at this point in the history