Refactor sample data sanitizer specs #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it easier to test the cases on an individual basis. This way not all the tests break if I want to change one thing about them.
tombruijn
force-pushed
the
refactor-hash-sanitizer-specs
branch
2 times, most recently
from
c251741
to
9930d5c
Compare
It doesn't just sanitize Hashes, but also Arrays (as the root object).
tombruijn
force-pushed
the
refactor-hash-sanitizer-specs
branch
from
9930d5c
to
3ee0ada
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor HashSanitizer specs
Make it easier to test the cases on an individual basis. This way not all the tests break if I want to change one thing about them.
Rename HashSanitizer to SampleDataSanitizer
It doesn't just sanitize Hashes, but also Arrays (as the root object).
[skip changeset]
[skip review]