Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor sample data sanitizer specs #1299

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Refactor sample data sanitizer specs #1299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6f934b
Refactor HashSanitizer specs
tombruijn Sep 16, 2024
3ee0ada
Rename HashSanitizer to SampleDataSanitizer
tombruijn Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/appsignal/transaction.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,7 +707,7 @@ def sanitized_params
return unless Appsignal.config[:send_params]

filter_keys = Appsignal.config[:filter_parameters] || []
Appsignal::Utils::HashSanitizer.sanitize params, filter_keys
Appsignal::Utils::SampleDataSanitizer.sanitize(params, filter_keys)
end

def session_data
Expand All @@ -720,7 +720,8 @@ def session_data

# Returns sanitized session data.
#
# The session data is sanitized by the {Appsignal::Utils::HashSanitizer}.
# The session data is sanitized by the
# {Appsignal::Utils::SampleDataSanitizer}.
#
# @return [nil] if `:send_session_data` config is set to `false`.
# @return [nil] if the {#request} object doesn't respond to `#session`.
Expand All @@ -729,8 +730,9 @@ def session_data
def sanitized_session_data
return unless Appsignal.config[:send_session_data]

Appsignal::Utils::HashSanitizer.sanitize(
session_data, Appsignal.config[:filter_session_data]
Appsignal::Utils::SampleDataSanitizer.sanitize(
session_data,
Appsignal.config[:filter_session_data]
)
end

Expand Down
2 changes: 1 addition & 1 deletion lib/appsignal/utils.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ module Utils
require "appsignal/utils/integration_memory_logger"
require "appsignal/utils/stdout_and_logger_message"
require "appsignal/utils/data"
require "appsignal/utils/hash_sanitizer"
require "appsignal/utils/sample_data_sanitizer"
require "appsignal/utils/integration_logger"
require "appsignal/utils/json"
require "appsignal/utils/ndjson"
Expand Down
2 changes: 1 addition & 1 deletion lib/appsignal/utils/hash_sanitizer.rb → lib/appsignal/utils/sample_data_sanitizer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

module Appsignal
module Utils
class HashSanitizer
class SampleDataSanitizer
FILTERED = "[FILTERED]"
RECURSIVE = "[RECURSIVE VALUE]"

Expand Down
196 changes: 0 additions & 196 deletions spec/lib/appsignal/utils/hash_sanitizer_spec.rb
View file
Open in desktop

This file was deleted.

Loading
Loading