Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix storage corruption #345

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Fix storage corruption #345

merged 2 commits into from
Mar 27, 2023

Conversation

heueristik
Copy link
Contributor

Description

This PR fixes storage corruption introduced by the added lastMultisigSettingsChange variable.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@heueristik heueristik changed the title Fix storage corruption and changed variable visibility Fix storage corruption Mar 27, 2023
mathewmeconry
mathewmeconry approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@mathewmeconry mathewmeconry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heueristik heueristik merged commit 7d961be into develop Mar 27, 2023
@heueristik heueristik deleted the fix/change-storage-corruption branch March 27, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathewmeconry mathewmeconry mathewmeconry approved these changes

@Rekard0 Rekard0 Rekard0 approved these changes

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heueristik @mathewmeconry @Rekard0