Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix storage corruption #345

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Fix storage corruption #345

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f59c9a
Fix storage corruption and changed variable visibility
heueristik Mar 27, 2023
29fb97d
Change visibility
heueristik Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/contracts/src/plugins/governance/multisig/Multisig.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,6 @@ contract Multisig is
uint16 minApprovals;
}

/// @notice Keeps track at which the settings has been changed the last time.
/// @dev This variable is used to prevent proposal creations from happing in the same block as the settings have been changed.
uint64 public lastMultisigSettingsChange;

/// @notice The [ERC-165](https://eips.ethereum.org/EIPS/eip-165) interface ID of the contract.
bytes4 internal constant MULTISIG_INTERFACE_ID =
this.initialize.selector ^
Expand All @@ -81,6 +77,10 @@ contract Multisig is
/// @notice The current plugin settings.
MultisigSettings public multisigSettings;

/// @notice Keeps track at which block number the multisig settings have been changed the last time.
/// @dev This variable prevents a proposal from being created in the same block in which the multisig settings change.
uint64 public lastMultisigSettingsChange;

/// @notice Thrown when a sender is not allowed to create a proposal.
/// @param sender The sender address.
error ProposalCreationForbidden(address sender);
Expand Down Expand Up @@ -450,5 +450,5 @@ contract Multisig is
/// @dev This empty reserved space is put in place to allow future versions to add new
/// variables without shifting down storage in the inheritance chain.
/// https://docs.openzeppelin.com/contracts/4.x/upgradeable#storage_gaps
uint256[48] private __gap;
uint256[47] private __gap;
}