Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: cant edit values in a tile that has child tile(s) #4383

Closed
adamlodge opened this issue Jan 4, 2019 · 8 comments
Closed

bug: cant edit values in a tile that has child tile(s) #4383

adamlodge opened this issue Jan 4, 2019 · 8 comments
Assignees
@adamlodge
Labels
Priority: High sfport issue whose resolution may be supported by sfport project Type: Bug Something isn't working

Comments

@adamlodge
Copy link
Collaborator

To reproduce:

  1. Load attached resource model to Arches
  2. Add a value to Parent Tile Node
  3. Add a value to Child Tile Node
  4. Try to edit the value in Parent Tile Node

System will hang

https://app.zenhub.com/files/49451058/37fe3517-a282-41f9-9afb-07f68fee87b3/download
@adamlodge adamlodge added sfport issue whose resolution may be supported by sfport project Type: Bug Something isn't working labels Jan 4, 2019
@chiatt chiatt self-assigned this Jan 5, 2019
chiatt added a commit that referenced this issue Jan 5, 2019
@chiatt
Handles for cases when a tiles nodegroup is None, re #4383
9c9a350
@chiatt chiatt mentioned this issue Jan 5, 2019
Merged
@chiatt
Copy link
Member

chiatt commented Jan 5, 2019

@adamlodge I've merged in a fix for this. I still have to do a little more investigation to see why this problem occurred, so don't close this ticket right away.

chiatt added a commit that referenced this issue Jan 28, 2019
@chiatt
Locking critical mobile-survey properties once a survey has been sync…
61f3aa6 
…ed. re #4383, #4396, #4401, archesproject/arches-collector#329
chiatt added a commit that referenced this issue Jan 28, 2019
@chiatt
Locks users and groups if a survey has been synched. re #4383, #4396, #…
9dabd03 
…4401
@chiatt chiatt mentioned this issue Jan 28, 2019
Merged
veuncent added a commit that referenced this issue Feb 2, 2019
@veuncent
Merge branch 'master' of https://github.com/archesproject/arches into…
929f0c3 
… official_master

* 'master' of https://github.com/archesproject/arches: (23 commits)
  Update loading mask message style
  Update instruction panel
  fix overflow on MSM default page, update status instructions
  download all concepts in a collection for the mobile app, re #4499
  Update pre-release testing script
  Update pre release script.
  removes uneeded classes, adds active-sub class behavior
  erases comments
  new search icon left nav-bar
  lints
  Enforces card order in the MSM and persists that order to the mobile app. Also fixes card dirty state issues. re #4487
  Update status message
  fix child cards not being added to the mobile survey, re #4472
  Add message for completed, inactive survey
  Only shows active survey message when a survey is active on the server. re #4357
  Notifies user why some features of the MSM are immutable once a survey has been synced. re #4401
  Start update to survey status details
  Locks users and groups if a survey has been synched. re #4383, #4396, #4401
  Fixes to user order so that dirty state does not persist once a user reverses their chanages to the user list.
  Locking critical mobile-survey properties once a survey has been synced. re #4383, #4396, #4401, archesproject/arches-collector#329
  ...
veuncent pushed a commit to globaldigitalheritage/arches that referenced this issue Feb 9, 2019
@chiatt @veuncent
Handles for cases when a tiles nodegroup is None, re archesproject#4383
3e7247b
@chiatt chiatt assigned adamlodge and unassigned chiatt Feb 13, 2019
@adamlodge
Copy link
Collaborator Author

meets requirementr

@veuncent
Copy link
Contributor

This may not yet work as expected: when I try to add data to a newly added node in an existing node group, the changes don't get picked up and the Save edits button does not appear.

@veuncent veuncent reopened this Feb 23, 2019
@adamlodge
Copy link
Collaborator Author

adamlodge commented Feb 23, 2019 via email

@veuncent
Copy link
Contributor

Yes exactly that :)

So in the resource editor I added some data to a few nodes in the same node group (resulting in a node group instance, if I understand the vocabulary correctly).

Then in the designer I added a new node to the node group.

Subsequently in the resource editor I tried adding a value to the newly added node. This resulted in the 'Save edits' button not appearing.

@adamlodge
Copy link
Collaborator Author

meets reqt

@adamlodge adamlodge reopened this Apr 4, 2019
@apeters
Copy link
Member

apeters commented Apr 5, 2019

if this is fixed, it should be closed

@chiatt
Copy link
Member

chiatt commented Apr 5, 2019

@adamlodge I just tested this and it worked fine for me in the latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamlodge adamlodge

Labels
Priority: High sfport issue whose resolution may be supported by sfport project Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@apeters @chiatt @veuncent @adamlodge