Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix card order in msm #4487

Closed
chiatt opened this issue Jan 29, 2019 · 2 comments
Closed

Fix card order in msm #4487

chiatt opened this issue Jan 29, 2019 · 2 comments
Assignees
@chiatt

Comments

@chiatt
Copy link
Member

chiatt commented Jan 29, 2019

Currently the card order in the msm is not preserved when a user saves a survey. This can result in cards being unpredictably ordered in the mobile app. By default, cards should follow the order they are in in the graph designer. re archesproject/arches-collector#305
@chiatt chiatt transferred this issue from archesproject/arches-collector Jan 29, 2019
@chiatt chiatt self-assigned this Jan 29, 2019
chiatt added a commit that referenced this issue Jan 30, 2019
@chiatt
Enforces card order in the MSM and persists that order to the mobile …
f05ac1d 
…app. Also fixes card dirty state issues. re #4487
@chiatt chiatt mentioned this issue Jan 30, 2019
Merged
@chiatt chiatt assigned apeters and unassigned chiatt Jan 30, 2019
@apeters
Copy link
Member

apeters commented Jan 30, 2019

This still seems broken to me. I updated an existing graph in a mobile survey by re-ordering both the cards and the nodes, but neither of those edits seem to get down to the mobile app itself.

@apeters apeters assigned chiatt and unassigned apeters Jan 30, 2019
veuncent added a commit that referenced this issue Feb 2, 2019
@veuncent
Merge branch 'master' of https://github.com/archesproject/arches into…
929f0c3 
… official_master

* 'master' of https://github.com/archesproject/arches: (23 commits)
  Update loading mask message style
  Update instruction panel
  fix overflow on MSM default page, update status instructions
  download all concepts in a collection for the mobile app, re #4499
  Update pre-release testing script
  Update pre release script.
  removes uneeded classes, adds active-sub class behavior
  erases comments
  new search icon left nav-bar
  lints
  Enforces card order in the MSM and persists that order to the mobile app. Also fixes card dirty state issues. re #4487
  Update status message
  fix child cards not being added to the mobile survey, re #4472
  Add message for completed, inactive survey
  Only shows active survey message when a survey is active on the server. re #4357
  Notifies user why some features of the MSM are immutable once a survey has been synced. re #4401
  Start update to survey status details
  Locks users and groups if a survey has been synched. re #4383, #4396, #4401
  Fixes to user order so that dirty state does not persist once a user reverses their chanages to the user list.
  Locking critical mobile-survey properties once a survey has been synced. re #4383, #4396, #4401, archesproject/arches-collector#329
  ...
@chiatt
Copy link
Member Author

chiatt commented Feb 6, 2019

@apeters If you change the graph you would need to resave the survey with those changes. The MSM card order is independent of the graphs card order once the survey is saved.

@chiatt chiatt closed this as completed Feb 14, 2019
chiatt added a commit that referenced this issue Feb 16, 2019
@chiatt
Sorts cards in the MSM if cards have a sort order, re #4487
39aa7fe
@chiatt chiatt mentioned this issue Feb 16, 2019
Merged
chiatt added a commit that referenced this issue Feb 16, 2019
@chiatt
Merge pull request #4583 from archesproject/4487_card_order
8d3a799 
Sorts cards in the MSM if cards have a sort order, re #4487
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chiatt chiatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apeters @chiatt