-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INTEGRATION] JupyterLab integration due to upstream dependency constraint on Rich #3407
Comments
Hello! When we integrated Now I've installed the most recent version (13.4.2), and the aforementioned issue does not occur anymore. Because of this, I think we can lift the I'll make a PR for this.
|
Thanks for this @tomaarsen - I was hoping that this was the reason for pinning the version and it wouldn't impact on anything elsewhere. Cheers for the speed 🚀 |
Closes #3407 Hello! # Description List version restriction of `rich`. This restriction of `<= 13.0.1` was introduced in #2350 due to a [bug](Textualize/rich#2800 (comment)) in the version that was most recent back then: version 13.1.0. However, the issue has been resolved as of the current most recent version: 13.4.2. Additionally, #3407 suggests allowing at least up to 13.3.1. I think the best solution is just to let go of the version restriction and let pip/conda/poetry install the most recent version. **Type of change** (Please delete options that are not relevant. Remember to title the PR according to the type of change) - [x] Bug fix **How Has This Been Tested** I installed the most recent `rich` and experimented a bit with some scripts by making them crash etc. **Checklist** - [ ] I added relevant documentation - [ ] follows the style guidelines of this project - [x] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [ ] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) I'm of the opinion that this is not worthy of a changelog entry. --- - Tom Aarsen
Describe the bug
Tracebacks in jupyter notebooks in project virtual environment with
argilla
are broken as a result of upstream bug in old version ofrich
. Version constraint onrich = "<=13.0.1"
, this behaviour was fixed inrich==
v13.3.1.returns:
Expected behaviour
the traceback gets displayed correctly.
Environment:
Additional context
This bug is described in the following issues:
This doesn't affect my Argilla workflow other than making it a total pain to debug issues in notebooks! Hopefully a version bump isn't too onerous - it would be a massive QOL improvement.
suggested fix
Version bump rich e.g.
rich<=13.3.1
The text was updated successfully, but these errors were encountered: