Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Lift rich version restriction, see #3407 #3409

Merged

Conversation

tomaarsen
Copy link
Contributor

Closes #3407

Hello!

Description

List version restriction of rich. This restriction of <= 13.0.1 was introduced in #2350 due to a bug in the version that was most recent back then: version 13.1.0.
However, the issue has been resolved as of the current most recent version: 13.4.2.
Additionally, #3407 suggests allowing at least up to 13.3.1.

I think the best solution is just to let go of the version restriction and let pip/conda/poetry install the most recent version.

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix

How Has This Been Tested

I installed the most recent rich and experimented a bit with some scripts by making them crash etc.

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

I'm of the opinion that this is not worthy of a changelog entry.


  • Tom Aarsen

@tomaarsen tomaarsen changed the title Lift rich version restriction, see #3407 Fix: Lift rich version restriction, see #3407 Jul 14, 2023
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.16 🎉

Comparison is base (9be4b00) 90.28% compared to head (0ef26e8) 90.45%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3409      +/-   ##
===========================================
+ Coverage    90.28%   90.45%   +0.16%     
===========================================
  Files          243      243              
  Lines        12966    13130     +164     
===========================================
+ Hits         11707    11877     +170     
+ Misses        1259     1253       -6     

see 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

pyproject.toml Outdated Show resolved Hide resolved
@tomaarsen tomaarsen merged commit 62b0803 into argilla-io:develop Jul 14, 2023
15 checks passed
@tomaarsen tomaarsen deleted the integration/lift_rich_restriction branch July 14, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[INTEGRATION] JupyterLab integration due to upstream dependency constraint on Rich
2 participants