Use the correct encoding for ethers hashes in the bridge's conversion logic
#1427
Comments
|
Reopening because this is not yet implemented. |
github-merge-queue bot
pushed a commit
that referenced
this issue
Sep 16, 2024
## Summary Use the correct encoding functions to populate memo field in the bridge's conversion logic from rollup withdrawal events to sequencer actions. ## Background We were using `ethers::H256::to_string()` to get the string for the `rollup_transaction_hash` value, which returns a shortened version of the hash. the string `0x1234...0x1234` is instead of the full hash (i.e. you would expect it to give you something like `0x1234567890123456789012345678901234567890123456789012345678901234`). ## Changes - Use the correct ## Breaking Changelist - The previously invalid memo data will now be populated with the correct information. This doesn't actually break anything because we also aren't actually using these hashes anywhere. ## Related Issues Link any issues that are related, prefer full github links. closes #1427, #1471 --------- Co-authored-by: Richard Janis Goldschmidt <github@aberrat.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Essentially, we were using
ethers::H256::to_string()to get the string for therollup_transaction_hashvalue, which returns a shortened version of the hash. the string0x1234...0x1234is instead of the full hash (i.e. you would expect it to give you something like0x1234567890123456789012345678901234567890123456789012345678901234). The fix is to useencode_hexinstead ofto_string.┆Issue Number: ENG-764
The text was updated successfully, but these errors were encountered: