fix(bridge-contracts): fix memo transaction hash encoding #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noot
approved these changes
Aug 29, 2024
SuperFluffy
approved these changes
Aug 29, 2024
crates/astria-bridge-withdrawer/tests/blackbox/helpers/test_bridge_withdrawer.rs
Outdated
Show resolved
Hide resolved
itamarreif
force-pushed
the
itamarreif/bridge-contracts/hash-fix
branch
2 times, most recently
from
8c03c0a
to
cd975cd
Compare
…idge_withdrawer.rs Co-authored-by: Richard Janis Goldschmidt <github@aberrat.io>
Co-authored-by: Richard Janis Goldschmidt <github@aberrat.io>
itamarreif
force-pushed
the
itamarreif/bridge-contracts/hash-fix
branch
from
cd975cd
to
45fef0d
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…idge-contracts/hash-fix
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…idge-contracts/hash-fix
itamarreif
force-pushed
the
itamarreif/bridge-contracts/hash-fix
branch
from
f31129f
to
44caf94
Compare
noot
reviewed
Sep 16, 2024
| @@ -502,6 +516,11 @@ impl GetWithdrawalActionsError { | |||
| fn log_without_transaction_hash(_log: &Log) -> Self { | |||
| Self(GetWithdrawalActionsErrorKind::LogWithoutTransactionHash) | |||
| } | |||
|
|
|||
| // XXX: Somehow identify the log? | |||
There was a problem hiding this comment.
don't think this error should ever happen, but maybe put the tx hash?
noot
reviewed
Sep 16, 2024
Comment on lines
38
to
39
| self.rollup_withdrawal_event_id.len() <= 256, | ||
| "rollup withdrawal event id must not be more than 64 bytes", |
steezeburger
added a commit
that referenced
this pull request
Sep 23, 2024
* main: feat(conductor): implement restart logic (#1463) fix: ignore `RUSTSEC-2024-0370` (#1483) fix, refactor(sequencer): refactor ics20 logic (#1495) fix(ci): use commit SHA instead of PR number preview-env images (#1501) chore(bridge-withdrawer): pass GRPC and CometBFT clients to consumers directly (#1510) fix(sequencer): Fix incorrect error message from BridgeUnlock actions (#1505) fix(bridge-contracts): fix memo transaction hash encoding (#1428) fix: build docker when workflow explicitly includes component (#1498) chore(sequencer): migrate from `anyhow::Result` to `eyre::Result` (#1387) fix(ci): typo for required field in sequencer preview-env (#1500) feat(ci): provide demo/preview environments (#1406)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use the correct encoding functions to populate memo field in the bridge's conversion logic from rollup withdrawal events to sequencer actions.
Background
We were using
ethers::H256::to_string()to get the string for therollup_transaction_hashvalue, which returns a shortened version of the hash. the string0x1234...0x1234is instead of the full hash (i.e. you would expect it to give you something like0x1234567890123456789012345678901234567890123456789012345678901234).Changes
Breaking Changelist
Related Issues
Link any issues that are related, prefer full github links.
closes #1427, #1471