-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bridge-contracts): fix memo transaction hash encoding #1428
Merged
Merged
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
738e11e
fix hash encoding
itamarreif d839d85
fix black box test
itamarreif 247b8ce
Update crates/astria-bridge-withdrawer/tests/blackbox/helpers/test_br…
itamarreif 45fef0d
Update crates/astria-bridge-contracts/src/lib.rs
itamarreif 8b6dc52
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif 0c348cf
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif 64317aa
dont save 0x in withdraw event id
itamarreif 8b89da3
change event id to 128
itamarreif c8ac63e
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif 44caf94
add log index to event id
itamarreif dfa0d5d
fix tests for erc20
itamarreif 7d5c98e
fix wrong line change
itamarreif a37aff5
fix ibc event id lenght
itamarreif cb7eea7
fix error msgs
itamarreif File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,7 +35,7 @@ impl ActionHandler for BridgeUnlockAction { | |
"rollup withdrawal event id must be non-empty", | ||
); | ||
ensure!( | ||
self.rollup_withdrawal_event_id.len() <= 64, | ||
self.rollup_withdrawal_event_id.len() <= 256, | ||
"rollup withdrawal event id must not be more than 64 bytes", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. update error message to |
||
); | ||
ensure!( | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't think this error should ever happen, but maybe put the tx hash?