Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Backstage metadata #534

Merged
merged 3 commits into from
Aug 25, 2022
Merged

Add Backstage metadata #534

merged 3 commits into from
Aug 25, 2022

Conversation

vzctl
Copy link
Member

@vzctl vzctl commented Jun 14, 2022

@sept-en Could you please review the precompiles piece and add description?
@joshuajbouw please check and feel free to add more info!

@vzctl vzctl requested a review from joshuajbouw as a code owner June 14, 2022 23:36
@joshuajbouw
Copy link
Contributor

Does anything more need to be added to this @vzctl ? I'm not too familiar with what could be added.

@vzctl
Copy link
Member Author

vzctl commented Jul 5, 2022

I would like to see a better description of what each component here does.

For example etc/eth-contracts/.catalog-info.yaml could be improved to reflect reality a bit more? I'm not entirely sure how accurate that description is.

Ideally every software component in this monorepo should have a catalog-info file describing what it and its relationship to the other components. We can add them later on...

etc/eth-contracts/.catalog-info.yaml Outdated Show resolved Hide resolved
engine/.catalog-info.yaml Show resolved Hide resolved
engine-precompiles/.catalog-info.yaml Show resolved Hide resolved
engine-precompiles/.catalog-info.yaml Show resolved Hide resolved
@joshuajbouw
Copy link
Contributor

joshuajbouw commented Jul 5, 2022

The engine-standalone-storage and engine-standalone-tracing currently is owned by the Protocol team. I figure that will change in the future, however. Its namely used in the borealis-engine.

engine-sdk is owned by us, and serves as our SDK for interfacing with NEAR. It is a component.

engine-transactions is owned by us and includes all the different kinds of ETH transactions.

engine-types is a shared types library that all other modules use.

@vzctl
Copy link
Member Author

vzctl commented Jul 19, 2022

All looks good to me! @sept-en is it good to go from your side?

Co-authored-by: Joshua J. Bouw <joshua@aurora.dev>
etc/eth-contracts/.catalog-info.yaml Outdated Show resolved Hide resolved
etc/eth-contracts/.catalog-info.yaml Show resolved Hide resolved
Co-authored-by: Kirill <kirill@aurora.dev>
@vzctl vzctl requested a review from joshuajbouw July 29, 2022 11:37
@vzctl vzctl merged commit 43ca751 into develop Aug 25, 2022
@vzctl vzctl deleted the chore-backstage branch August 25, 2022 16:47
birchmd pushed a commit that referenced this pull request Nov 15, 2022
* Add Backstage metadata

Co-authored-by: Joshua J. Bouw <joshua@aurora.dev>
Co-authored-by: Kirill <kirill@aurora.dev>
joshuajbouw added a commit that referenced this pull request Nov 25, 2022
* Chore(docs): Additional documentation for xcc gas values (#590)
* Feat(standalone): Conversion from standalone's TransactionKind to NormalizedEthTransaction (#586)
* Add Backstage metadata (#534)
* Add Backstage metadata
* Fix(aurora-engine-transactions): remove hex feaure from std (#600)
* Feat(tests): benchmark transaction Emufid2pv2UpxrZae4NyowF2N2ZHvYEPq16LsQc7Uoc6 (#599)
* Connector-tests: Add tests for the case where an account other than aurora-engine is used for ETH deposit (#598)
* [Docs] Eth Connector - extended documentation (#601)
* feat: add serde JSON to JSON serializable structs in parameters (#605)
* Pausable precompiles (#588)
* Test(engine): Increase unit test coverage (#614)
* Feat: allow xcc calls to perform any possible NEAR call (#610)
* Test(engine): Increase unit test coverage (#618)
* Refactor: Mark functions that create promises on NEAR as unsafe (#617)
* Fix(xcc): Only update the router contract version in storage if the deploy is successful (#616)
* Fix(CI): broken submodules checkout + Clippy warnings (#621)
* Chore(standalone): Upgrade rocksdb to v0.19. (#615)
* fix: remove sscache from CI (#626)
* Tiny refactoring by clippy suggestions (#625)
* Improvements in log macro (#630)
* Fix (engine): update SputnikVM dependency to avoid stack overflow on deeply nested EVM calls (#628)
* Fix(xcc): Ensure the xcc router attaches enough gas to the execute function (#622)
* Release 2.8.0 notes
* Build: Add reproducible build job. (#633)
* fix: bn 256 regression (#637)
* Update release notes
* Update README to exclude version (#623)
* Chore: Update to SputnikVM version v0.37.1-aurora. Includes some overflow-related fixes. (#638)
* fix: modexp underestimated gas
* chore: bump Cargo to 2.8
* chore: remove version from deployments in README.md

Co-authored-by: Alexey Lapitsky <lex@realisticgroup.com>
Co-authored-by: Joshua J. Bouw <joshua@aurora.dev>
Co-authored-by: Kirill <kirill@aurora.dev>
Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev>
Co-authored-by: Roman Hodulák <roman.hodulak@aurora.dev>
Co-authored-by: Dmitry Strokov <dmitry.strokov@aurora.dev>
Co-authored-by: Oleksandr Anyshchenko <aanischenko@gmail.com>
Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants