Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update udp ports information #478

Merged
merged 6 commits into from
Apr 1, 2024
Merged

Conversation

EmilFattakhov
Copy link
Contributor

Update with the changes introduced: autonomys/subspace#2647

Copy link

netlify bot commented Apr 1, 2024

Deploy Preview for subspace-docs-staging ready!

Name Link
🔨 Latest commit f3f2579
🔍 Latest deploy log https://app.netlify.com/sites/subspace-docs-staging/deploys/660b119efe70a20008b2a136
😎 Deploy Preview https://deploy-preview-478--subspace-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EmilFattakhov EmilFattakhov marked this pull request as ready for review April 1, 2024 17:28
Copy link
Member

@jim-counter jim-counter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QUIC is the UDP protocol we were using. And UDP/QUIC have been removed from all ports 30333, 30433 & 30533. Worth doing a search through the code for udp and quic.

@EmilFattakhov
Copy link
Contributor Author

@jim-counter right, I just re-read the original PR and I completely misread it 🤦 . The latest revision should be good!

Copy link
Member

@jim-counter jim-counter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thanks Emil!

@EmilFattakhov EmilFattakhov merged commit 15e723e into main Apr 1, 2024
5 checks passed
@EmilFattakhov EmilFattakhov deleted the update_udp_ports_information branch April 1, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants