Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove QUIC protocol support #2647

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Remove QUIC protocol support #2647

merged 3 commits into from
Mar 29, 2024

Conversation

nazar-pc
Copy link
Member

As discussed on the forum and further in Slack this PR removes QUIC support from Subspace networking stack.

Code contributor checklist:

Copy link
Member

@shamil-gadelshin shamil-gadelshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several entries related to UDP protocol left in the code (autonat wrapper seems more important among them). Otherwise, the changes work both in local and gemini-3h environments.

@nazar-pc
Copy link
Member Author

Autonat was the only thing I found and I kind of left it on purpose, but no strong opinion, so removed in latest commit

@shamil-gadelshin
Copy link
Member

Autonat was the only thing I found and I kind of left it on purpose, but no strong opinion, so removed in latest commit

Another entry is in the constructor.rs file. It's easy to find entries by searching "udp" string in the codebase.

@nazar-pc nazar-pc requested review from shamil-gadelshin and removed request for shamil-gadelshin March 29, 2024 09:24
@nazar-pc nazar-pc enabled auto-merge March 29, 2024 09:24
@nazar-pc nazar-pc added this pull request to the merge queue Mar 29, 2024
Copy link
Member

@shamil-gadelshin shamil-gadelshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, squash-merge it.

@nazar-pc nazar-pc removed this pull request from the merge queue due to a manual request Mar 29, 2024
@nazar-pc nazar-pc merged commit 8d18af2 into main Mar 29, 2024
9 checks passed
@nazar-pc nazar-pc deleted the remove-quic branch March 29, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants