build(ROS distribution)!: transition to ROS 2 Humble #2692

kenji-miyake · 2022-06-28T04:42:57Z

Description

Moved from autowarefoundation/autoware_core_universe_prototype#330.
Resolves #2443.

I won't merge this PR to main until the Galactic support by the AWF ends.
Users have to switch branches if they want to use Humble before that.
I've split the branches main(galactic) and humble because it would be too complex if we support both distros in one branch.

Tests performed

TIER IV has tested this in simulations and real vehicles.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.
The PR has been properly tested.
The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.
The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

autoware.repos

kenji-miyake · 2022-11-30T15:39:27Z

If #3089 is merged to main, the version 20.04should be replaced by 22.04.

amd64.env

ansible/roles/cuda/tasks/main.yaml

kenji-miyake · 2022-11-30T16:42:54Z

ansible/roles/rmw_implementation/README.md

 sudo apt update
-rosdistro=galactic
+rosdistro=humble


Probably we can remove this since amd64.env is sourced.
@xmfcx What do you think?

Suggested change

rosdistro=humble

If it works, we can do it.

Okay, I'll do it in another PR to keep the diff simple.

ansible/roles/ros2/README.md

xmfcx

I think we can merge this if CI can pass. (Since it installs the ansible scripts and builds the autoware)

kenji-miyake · 2022-11-30T17:06:16Z

@xmfcx Regarding build, we should manually trigger workflows because it's not triggered by the pull_request event due to the execution costs. So I'll check it tomorrow.

But before that, can I merge #3092 and #3093? They can reduce the diff of this PR.

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> docs(ansible/pre_commit): remove adding golang repository for humble (#2837) fix(docs): remove adding golang repository for humble Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> Signed-off-by: M. Fatih Cırıt <xmfcx@users.noreply.github.com>

…3054) This reverts commit 0d06dd3.

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

… documentation (#3007) Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com> Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com> build(ansible/ros2_dev_tools): follow updated humble documentation (#3020) Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com> Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

kenji-miyake · 2022-11-30T17:35:08Z

CI:

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

…ion#2692) * remove Go PPA Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> docs(ansible/pre_commit): remove adding golang repository for humble (autowarefoundation#2837) fix(docs): remove adding golang repository for humble Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> * rename galactic to humble Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * feat: add ament_cmake fork (autowarefoundation#370) Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> Signed-off-by: M. Fatih Cırıt <xmfcx@users.noreply.github.com> * revert(autoware.repos): revert "feat: add ament_cmake fork (autowarefoundation#370)" (autowarefoundation#3054) This reverts commit 0d06dd3. * update hash of grid_map Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * chore: remove grid_map from repos (autowarefoundation#2864) * use Ubuntu 22.04 and CUDA 11.8 Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * build(ansible/ros2_dev_tools): change ros2_dev_tools to follow humble documentation (autowarefoundation#3007) Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com> Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com> build(ansible/ros2_dev_tools): follow updated humble documentation (autowarefoundation#3020) Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com> Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com> * docs(ansible/cuda): update manual installation steps Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * tmp: use ubuntu:22.04 for cuda_base_image Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * tmp: add liburcu6 repository for CUDA 20.04 repository Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * feat(ansible/playbooks): update Ubuntu version Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Signed-off-by: M. Fatih Cırıt <xmfcx@users.noreply.github.com> Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com> Co-authored-by: M. Fatih Cırıt <xmfcx@users.noreply.github.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Shintaro Tomie <58775300+Shin-kyoto@users.noreply.github.com>

kenji-miyake mentioned this pull request Jun 28, 2022

feat: support ROS 2 Humble autowarefoundation/autoware_core_universe_prototype#330

Closed

4 tasks

wep21 reviewed Jul 1, 2022

View reviewed changes

autoware.repos Outdated Show resolved Hide resolved

kenji-miyake force-pushed the humble branch from d2feaef to ee7d37c Compare July 4, 2022 08:45

This was referenced Jul 4, 2022

Support ROS 2 Humble #2443

Closed

Support rolling(humble) autowarefoundation/autoware.universe#268

Closed

kenji-miyake force-pushed the humble branch from 352e555 to 5dc0c2e Compare August 10, 2022 12:19

kenji-miyake marked this pull request as ready for review September 1, 2022 07:04

kenji-miyake marked this pull request as draft September 1, 2022 07:04

kenji-miyake force-pushed the humble branch from 4812ac0 to bd93fb3 Compare November 30, 2022 10:47

kenji-miyake mentioned this pull request Nov 30, 2022

Transition to Humble #3083

Closed

32 tasks

kenji-miyake changed the title ~~feat(ROS distribution)!: transition to ROS 2 Humble~~ build(ROS distribution)!: transition to ROS 2 Humble Nov 30, 2022

kenji-miyake force-pushed the humble branch from bd93fb3 to f5c8c27 Compare November 30, 2022 10:59

kenji-miyake mentioned this pull request Nov 30, 2022

WIP: test Rolling #3086

Closed

4 tasks

kenji-miyake force-pushed the humble branch 2 times, most recently from 5102568 to 40a66c8 Compare November 30, 2022 14:43

kenji-miyake marked this pull request as ready for review November 30, 2022 15:23

kenji-miyake requested review from xmfcx and mitsudome-r November 30, 2022 15:23

xmfcx reviewed Nov 30, 2022

View reviewed changes

amd64.env Show resolved Hide resolved

xmfcx reviewed Nov 30, 2022

View reviewed changes

ansible/roles/cuda/tasks/main.yaml Show resolved Hide resolved

kenji-miyake commented Nov 30, 2022

View reviewed changes

ansible/roles/ros2/README.md Outdated Show resolved Hide resolved

xmfcx approved these changes Nov 30, 2022

View reviewed changes

Kenji Miyake and others added 5 commits December 1, 2022 02:22

rename galactic to humble

e55ba08

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

feat: add ament_cmake fork (#370)

aad3f5f

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> Signed-off-by: M. Fatih Cırıt <xmfcx@users.noreply.github.com>

revert(autoware.repos): revert "feat: add ament_cmake fork (#370)" (#…

ac30bf1

…3054) This reverts commit 0d06dd3.

update hash of grid_map

f268260

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

wep21 and others added 6 commits December 1, 2022 02:23

chore: remove grid_map from repos (#2864)

3383650

use Ubuntu 22.04 and CUDA 11.8

1854a43

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

docs(ansible/cuda): update manual installation steps

94b3a44

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

tmp: use ubuntu:22.04 for cuda_base_image

ec935c0

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

tmp: add liburcu6 repository for CUDA 20.04 repository

7282472

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

kenji-miyake force-pushed the humble branch from 71b49d1 to 7282472 Compare November 30, 2022 17:29

Merge remote-tracking branch 'origin/main' into humble

354fd1f

mitsudome-r approved these changes Dec 1, 2022

View reviewed changes

feat(ansible/playbooks): update Ubuntu version

3ea7527

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

mitsudome-r merged commit 9e35fd1 into main Dec 1, 2022

mitsudome-r deleted the humble branch December 1, 2022 12:11

tier4-autoware-public-bot bot mentioned this pull request Dec 2, 2022

chore: sync upstream tier4/autoware#5

Open

mitsudome-r mentioned this pull request Mar 17, 2023

grid_map_cv package fails to build autowarefoundation/autoware.universe#1827

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build(ROS distribution)!: transition to ROS 2 Humble #2692

build(ROS distribution)!: transition to ROS 2 Humble #2692

kenji-miyake commented Jun 28, 2022 •

edited by xmfcx

Loading

kenji-miyake commented Nov 30, 2022

kenji-miyake Nov 30, 2022

xmfcx Nov 30, 2022

kenji-miyake Nov 30, 2022

kenji-miyake Nov 30, 2022

xmfcx left a comment

kenji-miyake commented Nov 30, 2022

kenji-miyake commented Nov 30, 2022

build(ROS distribution)!: transition to ROS 2 Humble #2692

build(ROS distribution)!: transition to ROS 2 Humble #2692

Conversation

kenji-miyake commented Jun 28, 2022 • edited by xmfcx Loading

Description

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

kenji-miyake commented Nov 30, 2022

kenji-miyake Nov 30, 2022

Choose a reason for hiding this comment

xmfcx Nov 30, 2022

Choose a reason for hiding this comment

kenji-miyake Nov 30, 2022

Choose a reason for hiding this comment

kenji-miyake Nov 30, 2022

Choose a reason for hiding this comment

xmfcx left a comment

Choose a reason for hiding this comment

kenji-miyake commented Nov 30, 2022

kenji-miyake commented Nov 30, 2022

kenji-miyake commented Jun 28, 2022 •

edited by xmfcx

Loading