Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly evaluate process.env.AUTO_WEBP #195

Closed
wants to merge 1 commit into from

Conversation

toredash
Copy link

Description of changes:
process.env.AUTO_WEBP isn't properly evaluated. CloudFormation file sets this ENV to either "Yes" or "No", but the code only checks if the ENV variable is present or not.

Change was introduced with the bug present in #152

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@beomseoklee
Copy link
Member

Thanks for your contribution @toredash , and we are already aware of this issue, and we will fix this one on the next release.

@toredash
Copy link
Author

@beomseoklee should this PR be closed then, or do you wish to keep it open ?

mik3y added a commit to mik3y/serverless-image-handler that referenced this pull request Jul 12, 2020
@beomseoklee
Copy link
Member

@toredash
Thanks for waiting. This one is fixed in v5.0.0.

@toredash toredash closed this Sep 10, 2020
thisismana pushed a commit to thisismana/serverless-image-handler that referenced this pull request Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants