bugfix: Fix AUTO_WEBP handling.

Fixes aws-solutions#195 Fixes aws-solutions#200
mik3y · Jul 12, 2020 · 30ac339 · 30ac339
1 parent 6aae888
commit 30ac339
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,4 +8,5 @@
 * Removed the additional `custom-resource` lambda.
 * Use `yarn`.
 * Use `eslint` and `prettier`.
-* Add hermetic build using Docker (`make build/serverless-image-handler.zip`)
+* Add hermetic build using Docker (`make release`)
+* Bugfix: Fixed handling of `AUTO_WEBP` env flag.
diff --git a/image-request.js b/image-request.js
@@ -313,7 +313,7 @@ class ImageRequest {
    * @param {Object} event - The request body.
    */
   getOutputFormat(event) {
-    const autoWebP = process.env.AUTO_WEBP;
+    const autoWebP = process.env.AUTO_WEBP == "Yes";
     if (
       autoWebP &&
       event.headers.Accept &&

diff --git a/test/test-image-request.js b/test/test-image-request.js
@@ -754,7 +754,7 @@ describe("getOutputFormat()", () => {
     it('Should pass if it returns "webp" for an accepts header which includes webp', () => {
       // Arrange
       process.env = {
-        AUTO_WEBP: true,
+        AUTO_WEBP: "Yes",
       };
       const event = {
         headers: {
@@ -773,7 +773,7 @@ describe("getOutputFormat()", () => {
     it("Should pass if it returns null for an accepts header which does not include webp", () => {
       // Arrange
       process.env = {
-        AUTO_WEBP: true,
+        AUTO_WEBP: "Yes",
       };
       const event = {
         headers: {
@@ -792,7 +792,7 @@ describe("getOutputFormat()", () => {
     it("Should pass if it returns null when AUTO_WEBP is disabled with accepts header including webp", () => {
       // Arrange
       process.env = {
-        AUTO_WEBP: false,
+        AUTO_WEBP: "No",
       };
       const event = {
         headers: {