Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[codebuild] support LogsConfig and QueuedTimeoutInMinutes in L2 construct #11364

Closed
2 tasks
zxkane opened this issue Nov 9, 2020 · 3 comments · Fixed by #13467, linz/geostore#393, sullis/aws-cdk-java-example#66, thoughtworks/tramchester#254 or linz/elasticsearch-shipper#240
Closed
2 tasks

[codebuild] support LogsConfig and QueuedTimeoutInMinutes in L2 construct #11364

zxkane opened this issue Nov 9, 2020 · 3 comments · Fixed by #13467, linz/geostore#393, sullis/aws-cdk-java-example#66, thoughtworks/tramchester#254 or linz/elasticsearch-shipper#240
Assignees
@skinny85
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@zxkane
Copy link
Contributor

zxkane commented Nov 9, 2020 •
edited
Loading

The CodeBuild L2 construct does not support LogsConfig and QueuedTimeoutInMinutes.

Use Case

Specify the LogsConfig and QueuedTimeoutInMinutes properties via L2 CodeBuild construct. Also those properties should be override when starting build via Step Functions integration. See #10356 for detail.

Proposed Solution

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@zxkane zxkane added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 9, 2020
@github-actions github-actions bot added the @aws-cdk/aws-codebuild Related to AWS CodeBuild label Nov 9, 2020
@zxkane
Copy link
Contributor Author

zxkane commented Nov 13, 2020

#11444 might implement LogsConfig

@skinny85
Copy link
Contributor

skinny85 commented Dec 5, 2020

#11444 might implement LogsConfig

Yep, only QueuedTimeoutInMinutes left. Should be easy by adding a queuedTimeout?: cdk.Duration property to CommonProjectProps.

@skinny85 skinny85 added effort/small Small work item – less than a day of effort p2 good first issue Related to contributions. See CONTRIBUTING.md and removed needs-triage This issue or PR still needs to be triaged. labels Dec 5, 2020
@ialford ialford mentioned this issue Mar 8, 2021
Merged
@mergify mergify bot closed this as completed in #13467 Mar 8, 2021
mergify bot pushed a commit that referenced this issue Mar 8, 2021
@ialford
feat(codebuild): allow setting queued timeout (#13467)
e09250b 
Closes #11364

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Mar 8, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

cornerwings pushed a commit to cornerwings/aws-cdk that referenced this issue Mar 8, 2021
@ialford @cornerwings
feat(codebuild): allow setting queued timeout (aws#13467)
827af64 
Closes aws#11364

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Mar 12, 2021
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Closed
This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(codebuild): allow setting queued timeout ialford/aws-cdk
build(deps): bump aws-cdk from 1.92.0 to 1.93.0 linz/geostore
build(deps): bump cdk.version from 1.92.0 to 1.93.0 sullis/aws-cdk-java-example
[skip ci]: Bump aws-cdk from 1.91.0 to 1.93.0 thoughtworks/tramchester
build(deps-dev): bump aws-cdk from 1.92.0 to 1.93.0 linz/elasticsearch-shipper
Bump aws-cdk from 1.91.0 to 1.93.0 in /setTopicAttributes Milan9805/cdk-set-topic-attributes
Bump aws-cdk from 1.91.0 to 1.93.0 in /deployGenericSnsTopic Milan9805/cdk-set-topic-attributes
chore(deps): bump @aws-cdk-containers/ecs-service-extensions from 1.92.0 to 1.93.0 nikovirtala/cdk-preview-environments
chore(deps-dev): bump aws-cdk from 1.92.0 to 1.93.0 nikovirtala/cdk-preview-environments
chore(deps): bump @aws-cdk/assert from 1.92.0 to 1.93.0 nikovirtala/cdk-preview-environments
2 participants
@skinny85 @zxkane