-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(codebuild): allow setting the Project's logging configuration #11444
Conversation
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @wulfmann !
I'd like to see the used classes changed a little bit (including their names), but looks pretty solid!
Pull request has been modified.
@skinny85 I've updated the changes you requested. One thing i'm curious about is how would I implement a helper to allow for both of these log configurations? Would I add another class that implements ProjectLogs like the others? A config can have both s3 and cloudwatch configurations. |
Oh shit. Is that really allowed? |
Yep, see the logs config section here |
Damn. I was not aware of that. I thought you could only have a single type of logs active in a given Project. In that case, your original design might be better 😕. Would you mind going back to the firs revision of this R? Apologies for the churn ❤️. |
Sure I’ll go back. In thinking about this, we might as well allow the enabled/disabled flag too. This might be the use case: Cloudwatch logging is enabled by default so if you only wanted to send to s3, you would have to pass in the cloudwatch block with disabled. Let me know your thoughts on that! |
Sure, but kill the enum. Just make it an |
Also, thanks! |
d79646d
to
166f9ea
Compare
Ok should be good to go for another review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @wulfmann ! Looks very good. Some comments below.
Pull request has been modified.
@skinny85 Alright I've made the corrections you suggested. Let me know if you see anything else that should be changed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're almost there @wulfmann , thanks for your patience!
The biggest thing is the naming: make sure all places use camelCase, so CloudWatch
, not Cloudwatch
.
Thanks!
Pull request has been modified.
@skinny85 Alright ready for another round. I appreciate your thoroughness!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fantastic. Thanks for the great contribution @wulfmann , and for your patience in dealing with my barrage of comments! 😬
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…2213) In #11444, we added the option of setting the logging configuration of the Project. Unfortuantely, the Project's Role was not given permissions to write into that destination, which means executing the Project's build would fail. Fixes #12179 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…s#12213) In aws#11444, we added the option of setting the logging configuration of the Project. Unfortuantely, the Project's Role was not given permissions to write into that destination, which means executing the Project's build would fail. Fixes aws#12179 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Fixes: #3856
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license