fix(elbv2): metric(Un)HealthyHostCount don't use TargetGroup dimension #10697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both the HealthyHostCount and UnHealthyHostCount metrics require the TargetGroup as a dimension, in addition to the LoadBalancer dimension. The current `NetworkLoadBalancer.metric(Un)HealthyHostCount` methods don't account for this, and return broken metrics. The methods can't even be properly fixed to do the right thing, because the proper solution results in one metric per TargetGroup, whereas the current signature returns a single `IMetric`. Moving the metrics to the TargetGroup will provide a way to get at these metrics. fixes #5046
rix0rrr
approved these changes
Oct 5, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the HealthyHostCount and UnHealthyHostCount metrics require the TargetGroup
as a dimension, in addition to the LoadBalancer dimension. The current
NetworkLoadBalancer.metric(Un)HealthyHostCountmethods don't account for this,and return broken metrics. The methods can't even be properly fixed to do the
right thing, because the proper solution results in one metric per TargetGroup,
whereas the current signature returns a single
IMetric.Moving the metrics to the TargetGroup will provide a way to get at these metrics.
fixes #5046
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license