Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(elbv2): metric(Un)HealthyHostCount don't use TargetGroup dimension #10697

Merged
merged 2 commits into from
Oct 5, 2020
Merged

fix(elbv2): metric(Un)HealthyHostCount don't use TargetGroup dimension #10697

merged 2 commits into from
Oct 5, 2020

Commits on Oct 5, 2020

  1. fix(elbv2): metric(Un)HealthyHostCount don't use TargetGroup dimension 

    Both the HealthyHostCount and UnHealthyHostCount metrics require the TargetGroup
as a dimension, in addition to the LoadBalancer dimension. The current
`NetworkLoadBalancer.metric(Un)HealthyHostCount` methods don't account for this,
and return broken metrics. The methods can't even be properly fixed to do the
right thing, because the proper solution results in one metric per TargetGroup,
whereas the current signature returns a single `IMetric`.

Moving the metrics to the TargetGroup will provide a way to get at these metrics.

fixes #5046
    @njlynch
    njlynch committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    2cfaf10 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into njlynch/elbv2-healthy-host-count

    @mergify
    mergify[bot] authored Oct 5, 2020
    Configuration menu
    Copy the full SHA
    54270a5 View commit details
    Browse the repository at this point in the history