Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(doc): add Windows description in contributing guide #25397

Merged
merged 4 commits into from
May 25, 2023

Conversation

pahud
Copy link
Contributor

@pahud pahud commented May 2, 2023

We are having some known issues to clone or build aws-cdk on Windows such as #23910 and #25164. Before we can address those issues, we should encourage Windows developers to use Gitpod or CodeCatalyst Dev Env on their Windows instead.

Closes #23910 #25164


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 2, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team May 2, 2023 16:01
@github-actions github-actions bot added bug This issue is a bug. p2 labels May 2, 2023
@pahud pahud marked this pull request as ready for review May 2, 2023 16:01
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 2, 2023
Copy link
Contributor

@Naumel Naumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting a more positive phrasing

CONTRIBUTING.md Outdated Show resolved Hide resolved
@corymhall corymhall added the docs/repo-general Related to repo documentation (CONTRIBUTING, CODE_OF_CONDUCT, etc.) label May 8, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 8, 2023
Co-authored-by: Naumel <104374999+Naumel@users.noreply.github.com>
@mergify
Copy link
Contributor

mergify bot commented May 25, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 25, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b33d558
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 43d2060 into aws:main May 25, 2023
@mergify
Copy link
Contributor

mergify bot commented May 25, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. docs/repo-general Related to repo documentation (CONTRIBUTING, CODE_OF_CONDUCT, etc.) p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contributing: Unable to buildup on Windows
5 participants