Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cognito): user pool domain #7224

Merged
merged 14 commits into from
Apr 22, 2020
Merged

feat(cognito): user pool domain #7224

merged 14 commits into from
Apr 22, 2020

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Apr 7, 2020 •
edited
Loading

Commit Message

feat(cognito): user pool domain (#7224)

Support for user pool domains in the Cognito module.
Domains can be explicitly configured for either custom domain or Cognito
hosted prefix domains.

Added 'cloudFrontDomainName' property that gets the CloudFront domain
name by calling DescribeUserPoolDomain API via a custom resource.

closes #6787.

End Commit Message

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

feat(cognito): user pool domains
fd7a7a2 
Support for user pool domains in the Cognito module.
Domains can be explicitly configured for either custom domain or Cognito
hosted prefix domains.
@nija-at nija-at requested a review from a team April 7, 2020 10:03
@nija-at nija-at self-assigned this Apr 7, 2020
@mergify mergify bot added contribution/core This is a PR that came from AWS. labels Apr 7, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: fd7a7a2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nija-at nija-at changed the title feat(cognito): user pool domains feat(cognito): user pool domain Apr 8, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: ee7ce75
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

rix0rrr
rix0rrr reviewed Apr 14, 2020
View reviewed changes
packages/@aws-cdk/aws-cognito/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-cognito/lib/user-pool-domain.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-cognito/lib/user-pool-domain.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-cognito/lib/user-pool-domain.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-cognito/lib/user-pool-domain.ts Outdated Show resolved Hide resolved
rix0rrr
rix0rrr previously requested changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turning this into "changes requested" for completeness, though most changes are under advisement :)

@nija-at nija-at requested a review from a team April 14, 2020 11:05
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: f3480f1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nija-at nija-at mentioned this pull request Apr 15, 2020
Merged
@nija-at nija-at removed the request for review from a team April 15, 2020 16:49
@nija-at nija-at requested a review from rix0rrr April 15, 2020 17:00
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: fdc5f07
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify bot pushed a commit that referenced this pull request Apr 16, 2020
chore(custom-resources): remove stepfunctions as a dependency (#7361)
3cf0561 
Swap stepfunction dependency with a custom implementation using
`CfnResource`.

Motivation
Construct libraries such as dynamodb and eks depend on this module to
implement its features. However, at the same time, this module depends
on lambda and stepfunctions construct libraries for its implementation.

This creates dependency cycles.
A simple example - to implement the dynamodb stepfunction task, the
`aws-stepfunctions-tasks` module  needs to depend on `aws-dynamodb`.
However, this creates a cycle such as stepfunctions-tasks → dynamodb →
custom-resources → stepfunctions-tasks.
Another instance is to pre-empt the dependency cycle that will be
introduced by #7224. This will create the cycle - batch → ecs →
route53-targets → cognito → custom-resources → stepfunctions-tasks →
batch.

Conceptually, custom-resources should sit at the bottom of the construct
library stack, taking dependencies on very few foundational CDK
libraries.
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 6ca59d2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nija-at nija-at changed the title feat(cognito): user pool domain feat(cognito): user pool domain & route53 target Apr 20, 2020
@nija-at nija-at changed the title feat(cognito): user pool domain & route53 target feat(cognito): user pool domain Apr 20, 2020
@nija-at nija-at requested a review from rix0rrr April 20, 2020 11:54
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: bc6d6d1
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nija-at nija-at dismissed rix0rrr’s stale review April 20, 2020 14:13

feedback addressed

@nija-at nija-at requested a review from a team April 20, 2020 14:13
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: d24ed79
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 81f0ef1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: c5eda23
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr rix0rrr added the pr/do-not-merge This PR should not be merged at this time. label Apr 21, 2020
rix0rrr
rix0rrr approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provisionally okay.

packages/@aws-cdk/aws-route53-targets/lib/userpool-domain.ts Show resolved Hide resolved
packages/@aws-cdk/aws-cognito/lib/user-pool-domain.ts Outdated
/**
* The type of user pool domain. Two types are currently supported - custom domain and cognito domain.
*/
export class UserPoolDomainType {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name is a little long for my tastes.

I don't know man. Maybe it was fine the first time, with 3 optional fields and some runtime validation. It feels like a pretty complicated dance right now very very little benefit right now.

Do with that as you will, I don't feel super strongly.

@nija-at nija-at removed the pr/do-not-merge This PR should not be merged at this time. label Apr 22, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 363de19
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 22, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 78a0118
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 43de607
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 22, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit feadd6c into master Apr 22, 2020
@mergify mergify bot deleted the nija-at/cognito-domain branch April 22, 2020 09:18
@ilkomiliev ilkomiliev mentioned this pull request Jun 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@nija-at nija-at

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create route53 ARecord for a user pool domain
3 participants
@nija-at @aws-cdk-automation @rix0rrr