There is already a Construct with name 'CloudFrontDomainName' in UserPoolDomain

[ilkomiliev]

Trying to add the Route53 entry for the UserPoolDomain more than one time (i.e. in the public and in the private zone) in a single stack causes the below error. I think the direct cause is that the id is hard-coded in the UserPoolDomainTarget, but the indirect cause is perhaps that the construct is initialized on each call to the UserPoolDomainTarget instead to be initialized once and then cached - but it could be that I'm wrong with this assumption.

Reproduction Steps

@unique
class HostedZoneTypesEnum(Enum):
    PUBLIC = 'public'
    PRIVATE = 'private'

def register_cf_domain_name(
        self, 
        scope: core.Construct,
        user_pool_domain: aws_cognito.UserPoolDomain
    ):
        upd_target = r53_targets.UserPoolDomainTarget(user_pool_domain)
        target = r53.RecordTarget.from_alias(upd_target)
        public_zone = fr53.import_hosted_zone(scope, 'hzpublic', HostedZoneTypesEnum.PUBLIC)
        self.create_route53_a_record(
            scope=scope,
            cid='r53recpub',
            target=target,
            zone=public_zone
        )
        private_zone = fr53.import_hosted_zone(scope, 'hzprivate', HostedZoneTypesEnum.PRIVATE)
        self.create_route53_a_record(
            scope=scope,
            cid='r53recpriv',
            target=target,
            zone=private_zone
        )

    def create_route53_a_record(
        self,
        scope: core.Construct,
        cid: str,
        target: r53.RecordTarget,
        zone: HostedZoneTypesEnum
    ):
        r53.ARecord(
            scope, 
            id=cid, 
            target=target, 
            zone=zone, 
            comment='Cognito CloudFront Alias', 
            record_name=self.cognito_config.domain_name
        )

Error Log

 File "/xxx/env/lib/python3.7/site-packages/jsii/_runtime.py", line 66, in __call__
    inst = super().__call__(*args, **kwargs)
  File "/xxx/env/lib/python3.7/site-packages/aws_cdk/aws_route53/__init__.py", line 3273, in __init__
    jsii.create(ARecord, self, [scope, id, props])
  File "/xxx/env/lib/python3.7/site-packages/jsii/_kernel/__init__.py", line 229, in create
    interfaces=[iface.__jsii_type__ for iface in getattr(klass, "__jsii_ifaces__", [])],
  File "/xxx/env/lib/python3.7/site-packages/jsii/_kernel/providers/process.py", line 333, in create
    return self._process.send(request, CreateResponse)
  File "/xxx/env/lib/python3.7/site-packages/jsii/_kernel/providers/process.py", line 318, in send
    raise JSIIError(resp.error) from JavaScriptError(resp.stack)
jsii.errors.JSIIError: There is already a Construct with name 'CloudFrontDomainName' in UserPoolDomain [xxx]

Environment

• CLI Version :1.45.0 (build 0cfab15)
• Framework Version: ?
• Node.js Version: v10.19.0
• OS : Amazon Linux 2
• Language (Version): Python 3.7.6

Other

relates to #7224

---

This is 🐛 Bug Report

[nija-at]

Thanks for filing this issue.

The error is a bug in the underlying call to cloudFrontDomainName. I've posted a fix here - #8622