fix(cognito): cannot add multiple route53 targets to the same user pool domain #8622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ol domain The root cause here is that calling `cloudFrontDomainName` getter on `UserPoolDomain` results in creating a custom resource with a fixed node id. This resulted in the error - "There is already a Construct with name 'CloudFrontDomainName' in UserPoolDomain". Changed the logic around so that the `CustomResource` construct is only created on first call to the getter, and is reused on subsequent calls. fixes #8603
github-actions
bot
added
@aws-cdk/aws-cognito
github-actions
bot
added
@aws-cdk/aws-route53-targets
@aws-cdk/aws-sam
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
SomayaB
removed
@aws-cdk/aws-route53
RomainMuller
approved these changes
Jun 25, 2020
njlynch
approved these changes
Jun 25, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause here is that calling
cloudFrontDomainNamegetter onUserPoolDomainresults in creating a custom resource with a fixed nodeid. This resulted in the error - "There is already a Construct with name
'CloudFrontDomainName' in UserPoolDomain".
Changed the logic around so that the
CustomResourceconstruct is onlycreated on first call to the getter, and is reused on subsequent calls.
fixes #8603
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license