Suppress unhelpful warnings on Ruby 2.7 #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `[Attribute#default_value]` on record initialized with a `:default_value` triggered the following warning: ``` instance variable @default_value_or_lambda not initialized ``` The warning's not particularly useful as the caller will simply get a `nil` and carry on anyway[1]. By setting the variable to `nil` for records without a `:default_value` we maintain this behaviour and suppress the warning. [1]: Later versions of Ruby simply suppress this warning
alextwoods
approved these changes
Jun 24, 2021
|
These look good - thanks for submitting! |
lsglick
reviewed
Sep 25, 2023
lsglick
added a commit
to lsglick/aws-sdk-ruby-record
that referenced
this pull request
Sep 25, 2023
The fix in aws#112 had the side effect of calling `type_cast` on `nil` if the `default_value` was unset or explicitly set to `nil`. Because the `StringSetMarshaler` and `NumericSetMarshaler` both convert `nil` to `Set.new`, this caused the default value in practice to become `Set.new` instead of `nil`. Ultimately this caused downstream effects such as always persisting empty or unset sets as `nil` despite the `#persist_nil?` returning `false`.
lsglick
added a commit
to lsglick/aws-sdk-ruby-record
that referenced
this pull request
Sep 25, 2023
The fix in aws#112 had the side effect of calling `type_cast` on `nil` if the `default_value` was unset. Because the `StringSetMarshaler` and `NumericSetMarshaler` both convert `nil` to `Set.new`, this caused the unset default value in practice to become `Set.new` instead of `nil`. Ultimately this caused downstream effects such as always persisting empty or unset sets as `nil` despite the `#persist_nil?` returning `false`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
[Attribute#default_value]on record initialized with a:default_valuetriggered the following warning:The warning's not particularly useful as the caller will simply get a
niland carry on anyway[1]. By setting the variable tonilforrecords without a
:default_valuewe maintain this behaviour andsuppress the warning.
[1]: Later versions of Ruby simply suppress this warning
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.