Allow default value for String/Numeric Sets to be unset #133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The fix in #112 had the side effect of calling
type_cast
onnil
if thedefault_value
was unset.Because the
StringSetMarshaler
andNumericSetMarshaler
both convertnil
toSet.new
, this caused the unset default value in practice to becomeSet.new
instead ofnil
.Ultimately this caused downstream effects such as always persisting empty or unset sets as
nil
despite the#persist_nil?
returningfalse
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.