Skip to content

Commit

Permalink
Fix issues in fetchSchema for OpenCypher (#245)
Browse files Browse the repository at this point in the history
* Add tests for fetchSchema in OpenCypher

* Fix fetchSchema when edge has no props

Some OpenCypher labels have no edges, but we were assuming they all did. This caused a null reference exception.

I changed the assumption to allow for empty edges and added a guard check to skip empty labels.

* Fix fetchSchema where edge labels is not an array

* Remove todo

* Fix failing test

* Remove unused result variable declaration

* Add .gitignore to /package/graph-explorer

* Remove console logging

* Add more tests, fix edge labels and counts

* Update packages/graph-explorer/.gitignore

Co-authored-by: Alexey Temnikov <alexey.temnikov@improving.com>

---------

Co-authored-by: Alexey Temnikov <alexey.temnikov@improving.com>
  • Loading branch information
kmcginnes and alexey-temnikov committed Mar 4, 2024
1 parent f82a663 commit 7778108
Show file tree
Hide file tree
Showing 3 changed files with 629 additions and 51 deletions.
2 changes: 2 additions & 0 deletions packages/graph-explorer/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
node_modules/
coverage/
Loading

0 comments on commit 7778108

Please sign in to comment.