Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React query ESLint and dev tools #437

Merged
merged 7 commits into from
Jun 17, 2024
Merged

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Jun 17, 2024

Description

  • Adds ESLint plugin for React Query
  • Adds React Query dev tools (disabled for production)
  • Fixes new lint issues
  • Removes unnecessary useMemo for query key (automatically memoized)
  • Moves retry and 1 minute cache to global React Query defaults (can be overridden per query if needed)
  • Add explorer to query key so connections are unique queries

Validation

  • Tested in development mode locally
  • Tested in built Docker container from local code to see production behavior

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes requested a review from vkagamlyk June 17, 2024 17:02
@kmcginnes kmcginnes marked this pull request as ready for review June 17, 2024 17:05
@kmcginnes kmcginnes merged commit 6feb2f5 into aws:main Jun 17, 2024
1 check passed
@kmcginnes kmcginnes deleted the react-query-eslint branch June 17, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants