Queue load #26
Queue load #26
Conversation
g2p
force-pushed
the
queue-load
branch
4 times, most recently
from
6f92802
to
3892aa6
Compare
It is possible to get by with matches!, but this is more convenient.
On the JS sender side at least, Session.queueLoad is deprecated in favour of Session.load with a queueData set on the loaded item.
This is useful to know when the player appears to be idle but is in fact loading the next track from a playlist.
Also, introduce the TryFrom trait and new error types. This removes all uses of unwrap from media.rs.
Queue item currently playing, loading, preloaded.
|
@g2p I see you're making changes to this PR from time to time, so I assume you're still actively working on it. Once you need any input or review, just tag me, and I'll circle back as soon as I can. Thanks! |
|
This one is good for review if you're up to it! I have more queue-related work in another branch, but it's interspersed with async stuff. I've published the app that motivated the changes: https://github.com/g2p/joujou. So, I'll go clean up the history and maybe ask for input on the async branch, because it would be easier for me to have the rest of the media queue work land on top of the async-related refactoring. |
Roger that!
Oh, nice, thanks for sharing!
Did you have a chance to chat with @fluffysquirrels to figure out how we can best proceed with the two competing "async conversion" PRs? (See context in #23 (comment)). I hope you folks can find a way to collaborate on that work in one way or another, since you both seem to have an interest in the project. |
I've added various features, mostly relating to queues, serializing and deserializing media messages in more detail.
Three commits add queue-related commands or fields to commands, three commits improve status deserialisation (including removing all uses of unwrap in that area), two commits add impls of common traits to public media types.
Looking at the new extended statuses, I've stayed close to the message format, but it might be more user-friendly to add extended states to the original PlayerState enum; the next release will already break compat by adding stuff to the error enum anyway.