Added load command options with backwards compatibility #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @yoep, Thanks a lot for the contribution! Looks good to me. The linter on CI seems to complain, but I'll handle it myself separately. |
Merged
|
Hi @azasypkin Thanks for fixing the linter issues for me as I didn't saw the CI pipeline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR is related to feature request #29 .
I've replaced the hard-coded values within the
MediaRequestpayload through an additional provided fn namedload_with_opts, which allows backwards compatibility for the already existingloadfunction without creating duplicate code.Fixes: #29