forked from Azure/azure-sdk-for-js
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutoPR @azure/arm-recoveryservices-siterecovery] Review request for Microsoft.RecoveryServices to add version stable/2024-01-01 #8109
Closed
azure-sdk
wants to merge
55
commits into
main
from
sdkAuto/27261/@azure_arm-recoveryservices-siterecovery
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
force-pushed
the
sdkAuto/27261/@azure_arm-recoveryservices-siterecovery
branch
from
January 5, 2024 14:54
2412993
to
5a84d17
Compare
6 tasks
azure-sdk
force-pushed
the
sdkAuto/27261/@azure_arm-recoveryservices-siterecovery
branch
3 times, most recently
from
January 30, 2024 10:15
9c1655f
to
b0817e1
Compare
azure-sdk
force-pushed
the
sdkAuto/27261/@azure_arm-recoveryservices-siterecovery
branch
12 times, most recently
from
February 20, 2024 06:37
9325d1a
to
da71a75
Compare
…ents (Azure#28823) ### Packages impacted by this PR @azure/monitor-opentelemetry
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7842 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Anne Thompson <annelo@microsoft.com>
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7835 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
…ure#28842) Sync .github/workflows directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7845 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: James Suplizio <jasupliz@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
### Packages impacted by this PR @azure/identity ### Issues associated with this PR Nightly test failures ### Describe the problem that is addressed by this PR Our nightly tests started failing with a `TypeError: Descriptor for property generatePluginConfiguration is non-configurable and non-writable` error. I'm far from an expert here, but I believe the error is due to ESModules being immutable, whereas CJS Modules are mutable. Wrapping the stubbable / mockable object is a reasonable workaround to keep tests green regardless of whether they get run as ESM or CJS ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? Deleting the tests is an option, or an integration test. Neither seem to fit the bill here. Once we have credentials migrated over we may be able to delete some of the unit tests and rely on recorded tests to test the various scenarios. But we are not there yet.
… Package (Azure#28827) ### Packages impacted by this PR @azure/monitor-opentelemetry ### Describe the problem that is addressed by this PR Package should be updated to the latest version and tests updated appropriately. ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [x] Added a changelog (if necessary)
### Packages impacted by this PR @azure/core-client ### Issues associated with this PR N/A, follow up on Azure#28631 ### Describe the problem that is addressed by this PR If you are exporting both CommonJS and ESM forms of a package, then it is possible for both versions to be loaded at run-time. However, the CommonJS build is a different module from the ESM build, and thus a different thing from the point of view of the JavaScript interpreter in Node.js. https://github.com/isaacs/tshy/blob/main/README.md#dual-package-hazards tshy handles this by building programs into separate folders and treats "dual module hazards" as a fact of life. One of the hazards of dual-modules is shared module-global state. In core-clientwe have a module-global operationRequestMap that is used for deserializing. In order to ensure it works in this dual-package world we must use one of multiple-recommended workarounds. In this case, the tshy documentation provides a solution to this with a well-documented path forward. This is what is implemented here. Please refer to https://github.com/isaacs/tshy/blob/main/README.md#module-local-state for added context ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? The obvious alternative is to just not do anything since tests have not been failing; however, that seems risky. While _this_ particular issue has not come up in tests, a similar one came up for core-tracing. I am open to just _not_ doing anything of course - I love not adding code so just give me a reason!
…8840) ### Packages impacted by this PR @azure/monitor-opentelemetry-exporter
### Packages impacted by this PR - @azure/dev-tool ### Issues associated with this PR ### Describe the problem that is addressed by this PR Reverts back to the original for the testing ts-node for JS and TS. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ - Azure#28801 ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
Update emitter packages.
…ure#28864) Sync .github/workflows directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7848 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: James Suplizio <jasupliz@microsoft.com>
### Packages impacted by this PR - @azure/keyvault-keys - @azure/keyvault-admin - @azure/keyvault-secrets ### Describe the problem that is addressed by this PR Fixes the glob path issue with the upgrade to `rimraf` since there were extra calls to `rimraf` after the standard calls.
### Packages impacted by this PR - `@azure/core-lro` ### Describe the problem that is addressed by this PR In the ESM migration it appears we accidentally removed the `files` section from package.json for this package, so the built and packed package includes everything including the source code. This PR restores the field in line with the other ESMified Core packages.
azure-sdk
force-pushed
the
main
branch
2 times, most recently
from
March 14, 2024 06:30
f9892bb
to
34da487
Compare
azure-sdk
force-pushed
the
sdkAuto/27261/@azure_arm-recoveryservices-siterecovery
branch
from
March 14, 2024 12:48
da71a75
to
0338823
Compare
### Packages impacted by this PR @azure/monitor-opentelemetry Fixed issue with quickpulse document duration Fixed issue with miscalculation in dependency duration metric Updated default quickpulse endpoint
Post release automated changes for azure-core-lro
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7877 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Scott Beddall (from Dev Box) <scbedd@microsoft.com>
### Packages impacted by this PR `@azure-tools/test-recorder` ### Issues associated with this PR Azure#28667 ### Describe the problem that is addressed by this PR Releasing recorder 3.1.0 unblocks the Azure#28667 that upgrades recorder to 4.0.0 with vitest.
### Packages impacted by this PR @azure/communication-phone-numbers ### Issues associated with this PR ### Describe the problem that is addressed by this PR Update the Number Lookup public preview to include the Number Format features we've been preparing for GA. Azure/azure-rest-api-specs#27799 ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? This design has been reviewed by the stewardship board ### Are there test cases added in this PR? _(If not, why?)_ yes ### Provide a list of related PRs _(if any)_ Azure/azure-rest-api-specs#27799 Azure/azure-sdk-for-java#38885 .NET _pending_ Python _pending_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ n/a ### Checklists - [x] Added impacted package name to the issue description - [x] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [x] Added a changelog (if necessary)
### Packages impacted by this PR `@azure/dev-tool` ### Issues associated with this PR Fixing lint errors in `dev-tool` to unblock Azure#28916 and [js - eslint-plugin - ci](https://dev.azure.com/azure-sdk/public/_build/results?buildId=3595289&view=logs&j=58292cae-3c74-5729-4cfd-9ceee65fe129&t=5e44d412-b571-5a43-3bb4-5c5145c0a5aa)
### Packages impacted by this PR @azure/openai ### Issues associated with this PR Azure#28889
…kpulse (Azure#28931) ### Packages impacted by this PR @azure/monitor-opentelemetry
…28913) ### Packages impacted by this PR ### Issues associated with this PR ### Describe the problem that is addressed by this PR ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary) ### Packages impacted by this PR ### Issues associated with this PR ### Describe the problem that is addressed by this PR ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
azure-sdk
force-pushed
the
sdkAuto/27261/@azure_arm-recoveryservices-siterecovery
branch
2 times, most recently
from
March 15, 2024 15:43
9b92566
to
99a9371
Compare
### Packages impacted by this PR @azure/monitor-opentelemetry ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [x] Added a changelog (if necessary)
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7892 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
azure-sdk
force-pushed
the
sdkAuto/27261/@azure_arm-recoveryservices-siterecovery
branch
from
March 16, 2024 07:42
99a9371
to
4ed93b5
Compare
Merge 3b19762dab3c48c857ae2355da351b32dde22eda into 1790f2b6b51d4cb6f8dcc15ee742e98472fc7e01
azure-sdk
force-pushed
the
sdkAuto/27261/@azure_arm-recoveryservices-siterecovery
branch
from
March 16, 2024 15:26
4ed93b5
to
9171569
Compare
azure-sdk
deleted the
sdkAuto/27261/@azure_arm-recoveryservices-siterecovery
branch
March 24, 2024 09:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create to sync Azure/azure-rest-api-specs#27261
Please install the package by
npm install https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/27261/azure-sdk-for-js/@azure_arm-recoveryservices-siterecovery/azure-arm-recoveryservices-siterecovery-5.3.0.tgz