Update logger structure #981
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Heimdall Review Status
|
ricardoMogg
force-pushed
the
update_logger_structure
branch
from
5bcb278
to
7e63215
Compare
apps/web/src/utils/logger.ts
Outdated
| //TODO: initialice ddTrace through dd-tracer | ||
| if (ddTrace) { | ||
| // Access trace information server-side | ||
| const currentSpan = ddTrace?.scope().active(); |
There was a problem hiding this comment.
nit: should this be ddTrace.scope()?.active();? namely ddTrace? shouldn't be needed since we check above
There was a problem hiding this comment.
yeah this is true
| // Access trace information server-side | ||
| const currentSpan = ddTrace?.scope().active(); | ||
| traceId = currentSpan?.context().toTraceId() ?? undefined; | ||
| spanId = currentSpan?.context().toSpanId() ?? undefined; |
There was a problem hiding this comment.
similarly here currentSpan?.context()?.toSpanId() ? if context() is null or undefined we'll get an error.
There was a problem hiding this comment.
context() shouldn't be nil, since it is part of the definition of the object itself
apps/web/src/utils/logger.ts
Outdated
| } else { | ||
| console.log(`[${this.service}] ${message}`, meta); | ||
| console.log(JSON.stringify(logEntry)); |
There was a problem hiding this comment.
do we not want to use console.error() or console.warn() when those are the levels?
There was a problem hiding this comment.
otherwise can we structure this as
if (typeof console[level] === 'function') {
console[level](JSON.stringify(logEntry));
else {
console.log(JSON.stringify(logEntry));
}
?
There was a problem hiding this comment.
I'm using the previous condition for that. there is a warn and error function so it will be going to that. This else in particular is kind of overkill, everything should fall between the first other 2 conditions.
cb-heimdall
dismissed
dneilroth’s stale review
Approved review 2286700462 from dneilroth is now dismissed due to new commit. Re-request for approval.
cb-heimdall
dismissed
dneilroth’s stale review
Approved review 2286724283 from dneilroth is now dismissed due to new commit. Re-request for approval.
What changed? Why?
Update logger structure so that it is compatible with datadog. This will make errors look better in the logs explorer
Notes to reviewers
How has it been tested?
tested locally and in dev